From: Mathieu Othacehe <othacehe@gnu.org>
To: Jason Conroy <conjaroy@gmail.com>
Cc: 43540@debbugs.gnu.org
Subject: [bug#43540] [PATCH] Instantiate nscd in each system container instead of using the container host's service.
Date: Thu, 24 Sep 2020 10:01:16 +0200 [thread overview]
Message-ID: <87ft777gdv.fsf@gnu.org> (raw)
In-Reply-To: <CABWzUjUTyU03=-_-pK98zVSQLW7t1tW1euuBj97C_0UM-DOOPA@mail.gmail.com> (Jason Conroy's message of "Sun, 20 Sep 2020 18:05:02 -0400")
Hello Jason,
Thanks for this patch. You need to write a commit message that is
compliant with the ChangeLog format, see:
https://guix.gnu.org/manual/en/html_node/Submitting-Patches.html.
> +(define %nscd-container-caches
> + ;; Similar to %nscd-default-caches but with smaller cache sizes. This allows
> + ;; many containers to coexist on the same machine without exhausting RAM.
> + (list (nscd-cache (database 'hosts)
> + (positive-time-to-live (* 3600 12))
> + (negative-time-to-live 20)
> + (persistent? #t)
> + (max-database-size (expt 2 18)))
> + (nscd-cache (database 'services)
> + (positive-time-to-live (* 3600 24))
> + (negative-time-to-live 3600)
> + (check-files? #t) ;check /etc/services changes
> + (persistent? #t)
> + (max-database-size (expt 2 18)))))
You can write something like:
--8<---------------cut here---------------start------------->8---
(map (lambda (cache)
(nscd-cache
(inherit cache)
(max-database-size (expt 2 18)))) ;256KiB
%nscd-default-caches)
--8<---------------cut here---------------end--------------->8---
to avoid repeating the same values.
Otherwise, looks nice. Could you please send an updated version?
Thanks,
Mathieu
--
https://othacehe.org
next prev parent reply other threads:[~2020-09-24 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-20 22:05 [bug#43540] [PATCH] Instantiate nscd in each system container instead of using the container host's service Jason Conroy
2020-09-24 8:01 ` Mathieu Othacehe [this message]
2020-09-27 17:44 ` Jason Conroy
2020-10-01 7:29 ` bug#43540: " Mathieu Othacehe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft777gdv.fsf@gnu.org \
--to=othacehe@gnu.org \
--cc=43540@debbugs.gnu.org \
--cc=conjaroy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.