From: Christopher Baines <mail@cbaines.net>
To: Carl Dong <contact@carldong.me>
Cc: 46740@debbugs.gnu.org
Subject: [bug#46740] [PATCH] gnu: make-nsis: Fix build
Date: Wed, 24 Feb 2021 08:43:15 +0000 [thread overview]
Message-ID: <87ft1lluu4.fsf@cbaines.net> (raw)
In-Reply-To: <20210224030050.457744-1-contact@carldong.me>
[-- Attachment #1: Type: text/plain, Size: 3001 bytes --]
Carl Dong <contact@carldong.me> writes:
> * gnu/packages/installers.scm (make-nsis)[arguments]: Use
> C{,PLUS}_INCLUDE_PATH instead of CPATH environment variable to fix
> build.
> ---
> gnu/packages/installers.scm | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/installers.scm b/gnu/packages/installers.scm
> index a8a5c36a18..e8196b27d0 100644
> --- a/gnu/packages/installers.scm
> +++ b/gnu/packages/installers.scm
> @@ -96,9 +96,18 @@
> ;; CROSS_-prefixed version of env vars
> (setenv (string-append "CROSS_" env-name)
> (filter-delimited-string env-val mingw-path?))))
> - '("CPATH" "LIBRARY_PATH"))
> + '("C_INCLUDE_PATH" "CPLUS_INCLUDE_PATH" "LIBRARY_PATH"))
> ;; Hack to place mingw-w64 path at the end of search
> ;; paths. Could probably use a specfile and dirafter
> + (setenv "CROSS_C_INCLUDE_PATH"
> + (string-join
> + `(,@(map (cut string-append (assoc-ref %build-inputs "xgcc")
> + "/lib/gcc/" ,triplet "/"
> + ,(package-version xgcc) <>)
> + '("/include"
> + "/include-fixed"))
> + ,(getenv "CROSS_C_INCLUDE_PATH"))
> + ":"))
> (setenv "CROSS_CPLUS_INCLUDE_PATH"
> (string-join
> `(,@(map (cut string-append (assoc-ref %build-inputs "xgcc") <>)
> @@ -108,7 +117,7 @@
> ,@(map (cut string-append "/lib/gcc/" ,triplet "/" ,(package-version xgcc) <>)
> '("/include"
> "/include-fixed"))))
> - ,(getenv "CROSS_CPATH"))
> + ,(getenv "CROSS_CPLUS_INCLUDE_PATH"))
> ":"))))
> (add-before 'build 'fix-target-detection
> (lambda _
Hey!
Looks like this does fix things which is great [1], but it also
introduces some lint warnings [2].
1: https://data.guix-patches.cbaines.net/compare/package-derivations?base_commit=c418c6b64cbfa7a4eb1bfb7d02a99083103dd40e&target_commit=28d1e194346b3dae2ae4e969c00724d4d1037ff4&locale=en_US.UTF-8
2: https://data.guix-patches.cbaines.net/compare?base_commit=c418c6b64cbfa7a4eb1bfb7d02a99083103dd40e&target_commit=28d1e194346b3dae2ae4e969c00724d4d1037ff4
So, I'd remove the tabs and tweak the indentation so you're not
introducing any new long lines. But apart from that I think it's fine to
push, you can push right?
Chris
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2021-02-24 8:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-24 3:00 [bug#46740] [PATCH] gnu: make-nsis: Fix build Carl Dong
2021-02-24 8:43 ` Christopher Baines [this message]
2021-02-24 20:42 ` Carl Dong
2021-02-25 8:59 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ft1lluu4.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=46740@debbugs.gnu.org \
--cc=contact@carldong.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.