all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice <me@tobias.gr>
To: Guillaume Le Vaillant <glv@posteo.net>
Cc: guix-devel@gnu.org
Subject: Re: branch master updated: gnu: Add html2text.
Date: Tue, 27 Apr 2021 14:15:26 +0200	[thread overview]
Message-ID: <87fszbsz35.fsf@nckx> (raw)
In-Reply-To: <20210427113731.13295.67045@vcs0.savannah.gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1823 bytes --]

Guillaume,

guix-commits@gnu.org 写道:
> gnu: Add html2text.

Thanks!

This package is good but would've benefited from review.  Please 
submit all non-trivial patches to guix-patches@gnu.org first (if 
you did, I couldn't find it).  We've been too lax about this in 
the past, myself certainly included.

I've pushed some additional fixes[0]:

- The configure script is home-grown and simply ‘eval’s all 
  command-line arguments in the hope that they are variable 
  assignments.  Our defaults confuse it greatly:

--8<---------------cut here---------------start------------->8---
configure flags: 
("CONFIG_SHELL=/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash" 
"SHELL=/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash" 
"--prefix=/gnu/store/bblcx4gcchp7a5dp2y51wbmlh0212xz6-html2text-2.0.1_pre-1.05364c1" 
"--enable-fast-install" "--build=x86_64-unknown-linux-gnu")
./configure: line 25: eval: --: invalid option
eval: usage: eval [arg ...]
./configure: line 25: eval: --: invalid option
eval: usage: eval [arg ...]
--8<---------------cut here---------------end--------------->8---

Upstream didn't bother to add error checking, but we should still 
call it in the expected manner.

- Use #:make-flags etc. whenever possible rather than patching 
  build scripts.

- Cross-compilation was broken.  Building with 
  --target=aarch64-linux-gnu produced an x86_64 binary.  Fixed by 
  passing CXX to ./configure in the non-standard manner above.

- I noticed some 4-clause BSD headers & added them to the license 
  field.  This is purely informative: the result remains GPL2+.

Kind regards,

T G-R

[0]: 
https://git.savannah.gnu.org/cgit/guix.git/commit/?id=e009b8d7126531a2983701413c5b97e620e495e4 
and parents

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

       reply	other threads:[~2021-04-27 12:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210427113731.13295.67045@vcs0.savannah.gnu.org>
2021-04-27 12:15 ` Tobias Geerinckx-Rice [this message]
2021-04-27 13:06   ` branch master updated: gnu: Add html2text Guillaume Le Vaillant

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fszbsz35.fsf@nckx \
    --to=me@tobias.gr \
    --cc=glv@posteo.net \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.