From: Marius Bakke <marius@gnu.org>
To: Greg Hogan <code@greghogan.com>, 55057-done@debbugs.gnu.org
Subject: bug#55057: [PATCH core-updates] gnu: llvm-14, llvm-12: Enable RTTI.
Date: Thu, 01 Sep 2022 23:05:02 +0200 [thread overview]
Message-ID: <87fshabybl.fsf@gnu.org> (raw)
In-Reply-To: <CA+3U0ZkedMa1brxCjo0GbRSRpN2AG5X2pzWf5UszY6RdiFYtPA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
Greg Hogan <code@greghogan.com> skriver:
> The llvm packages currently define LLVM_REQUIRES_RTTI rather than the
> LLVM_ENABLE_RTTI flag specified in the LLVM documentation (
> https://llvm.org/docs/CMake.html).
>
> LLVM_REQUIRES_RTTI is noted as an internal flag in the llvm code (
> https://github.com/llvm/llvm-project/blob/llvmorg-14.0.1/llvm/cmake/modules/AddLLVM.cmake#L15
> ).
>
> This appears to have been an issue from the first Guix commit adding the
> LLVM_REQUIRES_RTTI flag as LLVM_ENABLE_RTTI is the flag specified in the
> documentation for llvm 3.8.1 (
> https://releases.llvm.org/3.8.1/docs/CMake.html).
> $ git show 83c49858b518b98f88db5f50ce36c19084e7ad62:gnu/packages/llvm.scm
Good catch. I wonder how we did not notice, apparently not many
packages depend on LLVM RTTI after all.
>>From 0cd3048f15fcca774088ab4d5b97a0fdaa74652e Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code@greghogan.com>
> Date: Thu, 21 Apr 2022 19:13:50 +0000
> Subject: [PATCH] gnu: llvm-14, llvm-12: Enable RTTI.
>
> * gnu/packages/llvm.scm (llvm-14, llvm-12): Enable RTTI.
> [arguments]<#:configure-flags>: Switch to proper CMake flag.
Applied, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]
prev parent reply other threads:[~2022-09-01 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 20:09 [bug#55057] [PATCH core-updates] gnu: llvm-14, llvm-12: Enable RTTI Greg Hogan
2022-09-01 21:05 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fshabybl.fsf@gnu.org \
--to=marius@gnu.org \
--cc=55057-done@debbugs.gnu.org \
--cc=code@greghogan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.