From: Andrew Tropin <andrew@trop.in>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Christopher Baines <mail@cbaines.net>, guix-devel@gnu.org
Subject: Re: branch master updated: gnu: emacs: Add TREE_SITTER_GRAMMAR_PATH support.
Date: Sun, 12 Feb 2023 08:24:47 +0400 [thread overview]
Message-ID: <87fsbby0hc.fsf@trop.in> (raw)
In-Reply-To: <87bklzn3jc.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]
On 2023-02-12 01:14, Ludovic Courtès wrote:
> Hi,
>
> Andrew Tropin <andrew@trop.in> skribis:
>
>> On 2023-02-11 16:35, Andrew Tropin wrote:
>
> [...]
>
>>>> The change to guix-emacs.el is pretty impactful here since that affects
>>>> all the emacs packages including emacs-minimal I think.
>>>>
>>>> If I've understood your comment correctly, that does seem pretty
>>>> wasteful since those rebuilds because of the changed emacs-minimal won't
>>>> have any affect since it's version 28 and not 29, right? I think
>>>> applying this change to just emacs-next would have been possible.
>>>
>>> It could be applied to emacs-next only and we could move it to emacs
>>> later when it updated to 29, but I checked guix refresh --list-dependent
>>> emacs and it shown less than 100 packages so I decided to apply it
>>> straight to emacs, but I forgot that emacs-minimal is inherited from
>>> emacs and I guess you are right and it will affect all the emacs
>>> packages. Anything we would like to do about it right now?
>>
>> Let's keep it as it is and I'll store it in mind for the next time.
>
> Right.
>
>> There is an idea to update guix refresh --list-dependent to handle the
>> case with inherited packages as well. WDYT?
>
> Unfortunately, it’s not possible because inheritance info isn’t
> available at run time.
>
> However, peer review and <https://qa.guix.gnu.org> should be able to
> catch it. No big deal, but next time we’ll know.
I need to figure out how to use qa service, it seems the patch
https://yhetil.org/87edqxri41.fsf@trop.in
is not recognized by
https://qa.guix.gnu.org/issue/49946
Probably it relies on subject for extracting apropriate patches for CI?
Will need to take a look at the source code, thank you for the idea.
--
Best regards,
Andrew Tropin
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2023-02-12 4:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <167610269975.14308.10330520524841229243@vcs2.savannah.gnu.org>
2023-02-11 11:29 ` branch master updated: gnu: emacs: Add TREE_SITTER_GRAMMAR_PATH support Christopher Baines
2023-02-11 12:35 ` Andrew Tropin
2023-02-11 16:54 ` Andrew Tropin
2023-02-12 0:14 ` Ludovic Courtès
2023-02-12 4:24 ` Andrew Tropin [this message]
2023-02-14 12:23 ` ’inherit’ and list-dependent (was Re: branch master updated: gnu: emacs: Add TREE_SITTER_GRAMMAR_PATH support.) Simon Tournier
2023-02-14 19:36 ` Gábor Boskovits
2023-02-21 22:55 ` Ludovic Courtès
2023-02-22 9:17 ` Simon Tournier
2023-02-25 18:10 ` Ludovic Courtès
2023-02-25 19:27 ` Gábor Boskovits
2023-02-27 9:59 ` Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsbby0hc.fsf@trop.in \
--to=andrew@trop.in \
--cc=guix-devel@gnu.org \
--cc=ludo@gnu.org \
--cc=mail@cbaines.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.