From: "Ludovic Courtès" <ludo@gnu.org>
To: Vivien Kraus <vivien@planete-kraus.eu>
Cc: 62181-done@debbugs.gnu.org
Subject: bug#62181: [PATCH v2 1/2] gnu: gnulib: Reset the shebangs.
Date: Fri, 17 Mar 2023 22:48:12 +0100 [thread overview]
Message-ID: <87fsa3vylf.fsf@gnu.org> (raw)
In-Reply-To: <6f1b6d6cfd135b7aa9c254b15b5aa8b04deee135.1678995685.git.vivien@planete-kraus.eu> (Vivien Kraus's message of "Tue, 14 Mar 2023 09:58:34 +0100")
Hi,
Vivien Kraus <vivien@planete-kraus.eu> skribis:
> * gnu/packages/build-tools.scm (gnulib) [phase reset-shebangs]: After
> installation, rewrite the /gnu/store shebangs in the distributed build-aux
> files.
> [inputs, native-inputs]: Add bash-minimal.
> [phase let-autogen-execute-gnulib-tool]: Specify a shell to execute
> gnulib-tool from autogen.sh.
Applied with tweaks to the commit log.
> + (substitute* (find-files
> + (string-append #$output "/src/gnulib")
> + (lambda (fname stat)
> + (and (not (string-suffix? "/lib/javaversion.class" fname))
> + (not (string-suffix? ".mo" fname)))))
This leaves the shebang on ‘bin/gnulib-tool’, such that ‘gnulib’ keeps a
reference to ‘bash-minimal’ (and nothing else).
It’s not even convenient though because…
> * gnu/packages/tls.scm (guile-gnutls) [phase patch-more-shebangs]: Fix how
> autogen.sh invokes gnulib-tool, and how configure.ac invokes git-version-gen,
> so as not to rely on shebangs.
[...]
> + (substitute* "autogen.sh"
> + (("\\$gnulib_tool \\$gnulib_tool_options")
> + "sh $gnulib_tool $gnulib_tool_options"))
… this is still needed: GNULIB/bin/gnulib-tool, which has a correct
shebang, is *not* used, and instead GNULIB/src/gnulib/gnulib-tool is
used.
Should we remove GNULIB/bin/gnulib-tool? Or should we remove the other
one?
Anyway, applied as well, thank you!
Ludo’.
next prev parent reply other threads:[~2023-03-17 21:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 8:34 bug#62181: Gnulib package keeps references to clisp, Python, Perl, and Bash Ludovic Courtès
2023-03-14 10:36 ` bug#62181: [PATCH 0/2] " Vivien Kraus via Bug reports for GNU Guix
2023-03-14 8:58 ` bug#62181: [PATCH 1/2] gnu: gnulib: Reset the shebangs Vivien Kraus via Bug reports for GNU Guix
2023-03-16 10:43 ` Ludovic Courtès
2023-03-14 10:33 ` bug#62181: [PATCH 2/2] gnu: guile-gnutls: Do not expect gnulib shebangs to work Vivien Kraus via Bug reports for GNU Guix
2023-03-16 10:48 ` Ludovic Courtès
2023-03-16 10:56 ` Vivien Kraus via Bug reports for GNU Guix
2023-03-16 10:41 ` bug#62181: [PATCH 0/2] Re: bug#62181: Gnulib package keeps references to clisp, Python, Perl, and Bash Ludovic Courtès
2023-03-16 10:54 ` Vivien Kraus via Bug reports for GNU Guix
2023-03-16 19:41 ` bug#62181: [PATCH v2 0/2] Drop references to other store items in /src, with better style Vivien Kraus via Bug reports for GNU Guix
2023-03-14 8:58 ` bug#62181: [PATCH v2 1/2] gnu: gnulib: Reset the shebangs Vivien Kraus via Bug reports for GNU Guix
2023-03-17 21:48 ` Ludovic Courtès [this message]
2023-03-18 9:06 ` Vivien Kraus via Bug reports for GNU Guix
2023-03-14 10:33 ` bug#62181: [PATCH v2 2/2] gnu: guile-gnutls: Do not expect gnulib shebangs to work Vivien Kraus via Bug reports for GNU Guix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsa3vylf.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=62181-done@debbugs.gnu.org \
--cc=vivien@planete-kraus.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.