all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Pierre Langlois <pierre.langlois@gmx.com>
To: 63348@debbugs.gnu.org
Cc: Efraim Flashner <efraim@flashner.co.il>
Subject: [bug#63348] [PATCH 0/4] Fix tree-sitter-cli build after 0.20.8 update.
Date: Sun, 07 May 2023 14:12:02 +0100	[thread overview]
Message-ID: <87fs88uvo4.fsf@gmx.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

Hi Guix and rust-team!

This series completes the 0.20.8 tree-sitter update by fixing the
tree-sitter-cli package. I actually had started working on it a few
weeks back, but never found the motivation to complete it until now!

Sadly, to do it I've had to disable tests, with notes to re-enable them
later, after the rust update. It seems that rust 1.65 is explicitely
required now: https://github.com/tree-sitter/tree-sitter/pull/2167/commits/da894afef59e1aefa23470c7db7445096f8f0e65
However, luckily, it looks like only the tests are using any code that
doesn't compile with 1.60.

Lastly, we need a newer version of the webbrowser rust crate, but it
pulls in a lot of unsupported dependencies. I see that we usually
include them, but in this case, doing so forces us to update core
windows-sys crates, which would cause a rebuild of librsvg :-/

It turned out to be a lot easier to just add a patch to remove android,
ios and macos dependencies manually.

Thanks,
Pierre

Pierre Langlois (4):
  gnu: Add rust-unindent-0.2.
  gnu: Update rust-tiny-http to 0.12.0.
  gnu: Add rust-webbrowser-0.8.
  gnu: tree-sitter-cli: Fix build with 0.20.8 version.

 gnu/local.mk                                  |  1 +
 gnu/packages/crates-io.scm                    | 62 ++++++++++++++++---
 ...ust-webbrowser-remove-unsupported-os.patch | 24 +++++++
 gnu/packages/tree-sitter.scm                  | 20 +++++-
 4 files changed, 95 insertions(+), 12 deletions(-)
 create mode 100644 gnu/packages/patches/rust-webbrowser-remove-unsupported-os.patch


base-commit: 8b855dc1f4a3e31c002c229ad4d91525f4ce97d3
-- 
2.39.2

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 519 bytes --]

             reply	other threads:[~2023-05-07 13:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-07 13:12 Pierre Langlois [this message]
2023-05-07 13:26 ` [bug#63348] [PATCH 1/4] gnu: Add rust-unindent-0.2 Pierre Langlois
2023-05-07 13:26   ` [bug#63348] [PATCH 2/4] gnu: Update rust-tiny-http to 0.12.0 Pierre Langlois
2023-05-07 13:26   ` [bug#63348] [PATCH 3/4] gnu: Add rust-webbrowser-0.8 Pierre Langlois
2023-05-07 13:26   ` [bug#63348] [PATCH 4/4] gnu: tree-sitter-cli: Fix build with 0.20.8 version Pierre Langlois
2023-05-07 16:49 ` bug#63348: [PATCH 0/4] Fix tree-sitter-cli build after 0.20.8 update Efraim Flashner
2023-05-07 17:10   ` [bug#63348] " Pierre Langlois

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs88uvo4.fsf@gmx.com \
    --to=pierre.langlois@gmx.com \
    --cc=63348@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.