From: Simon Tournier <zimon.toutoune@gmail.com>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: 65757-done@debbugs.gnu.org
Subject: [bug#65757] [PATCH] guix: packages: Support package/inherit by package-field-location.
Date: Thu, 07 Sep 2023 00:01:35 +0200 [thread overview]
Message-ID: <87fs3rm05c.fsf@gmail.com> (raw)
In-Reply-To: <875y4nqbk4.fsf@gmail.com>
Hi Maxim,
On Wed, 06 Sep 2023 at 16:41, Maxim Cournoyer <maxim.cournoyer@gmail.com> wrote:
> --8<---------------cut here---------------start------------->8---
> modified guix/packages.scm
> @@ -762,7 +762,7 @@ (define (package-field-location package field)
> (go-to-location port line column)
> (match (read port)
> ((or ('package inits ...)
> - ('package/inherit parent inits ...))
> + ('package/inherit _ inits ...))
> (let ((field (assoc field inits)))
> (match field
> ((_ value)
> --8<---------------cut here---------------end--------------->8---
>
> And it now works; yay! Will install shortly.
Oops! Indeed, sorry for missing the obvious. Thanks for the fix.
Cheers,
simon
PS: For the record, the change you made is:
- ('package/inherit inits ...))
+ ('package/inherit _ inits ...))
because the one above would be equivalent :-) – if I understand enough
Guile patterning matching.
next prev parent reply other threads:[~2023-09-06 22:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 14:37 [bug#65757] [PATCH] guix: packages: Support package/inherit by package-field-location Simon Tournier
2023-09-06 20:41 ` bug#65757: " Maxim Cournoyer
2023-09-06 22:01 ` Simon Tournier [this message]
2023-09-07 1:55 ` [bug#65757] " Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs3rm05c.fsf@gmail.com \
--to=zimon.toutoune@gmail.com \
--cc=65757-done@debbugs.gnu.org \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.