all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Hilton Chain via Guix-patches via <guix-patches@gnu.org>
To: Andrew Tropin <andrew@trop.in>
Cc: Emma Turner <mail@emturner.co.uk>, 66836@debbugs.gnu.org
Subject: [bug#66836] [Patch] gnu: Add tree-sitter-yaml.
Date: Sat, 18 Nov 2023 18:45:48 +0800	[thread overview]
Message-ID: <87fs13z6eb.wl-hako@ultrarare.space> (raw)
In-Reply-To: <87zfzb33tv.fsf@trop.in>

Hi Andrew,

On Sat, 18 Nov 2023 15:42:20 +0800,
Andrew Tropin wrote:
>
> > There seem to be formatting issue in your patch, making the last two lines
> > embedded into one: "--2.41.0".  You can have a look at it in [1].
> >
> > I think your changes can be shipped as a patch with Guix.  Maybe you can open a
> > PR to upstream as well? :)
>
> It seems that https://github.com/ikatyang/tree-sitter-yaml is
> unmaintained, that's probably why I didn't add this grammar earlier.
>
> So maybe forking and taking a maintainance is not a bad idea.

I have found the first tree-sitter commit causing the test failures, it's
0fb864c1a0a5a53a951e3bf830fdbdc5edac385d (v0.20.4-9-g0fb864c1), there's also
open issue for it[1].

And the tree-sitter-yaml repository actually has some relevant activity this
July[2].

Thanks
---
[1]:
Regression in YAML parsing with web-tree-sitter + tree-sitter-yaml
https://github.com/tree-sitter/tree-sitter/issues/2339

[2]:
https://github.com/ikatyang/tree-sitter-yaml/tree/feat/error-recovery




  reply	other threads:[~2023-11-18 10:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-29 20:47 [bug#66836] [Patch] gnu: Add tree-sitter-yaml Emma Turner via Guix-patches via
2023-11-04 12:15 ` Hilton Chain via Guix-patches via
2023-11-04 18:05   ` Emma Turner via Guix-patches via
2023-11-18  7:42   ` Andrew Tropin
2023-11-18 10:45     ` Hilton Chain via Guix-patches via [this message]
2023-11-04 12:22 ` [bug#66836] [PATCH v2] " Hilton Chain via Guix-patches via
2023-11-12 15:02   ` Hilton Chain via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs13z6eb.wl-hako@ultrarare.space \
    --to=guix-patches@gnu.org \
    --cc=66836@debbugs.gnu.org \
    --cc=andrew@trop.in \
    --cc=hako@ultrarare.space \
    --cc=mail@emturner.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.