all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Tomas Volf <~@wolfsden.cz>
Cc: 67722@debbugs.gnu.org
Subject: [bug#67722] [PATCH v2] gnu: libtorrent-rasterbar: Remove timeout for tests.
Date: Tue, 12 Dec 2023 09:11:07 +0100	[thread overview]
Message-ID: <87fs07263o.fsf@gnu.org> (raw)
In-Reply-To: <efda402a30daf66e5987b28bd124dbf6f552055e.1702150495.git.~@wolfsden.cz> (Tomas Volf's message of "Sat, 9 Dec 2023 20:34:55 +0100")

Hello,

Tomas Volf <~@wolfsden.cz> skribis:

> The timeout is still enforced by the build farm for the build as a whole, so
> it should not cause any builds to be permanently stuck.
>
> * gnu/packages/bittorrent.scm
> (libtorrent-rasterbar)[arguments]<#:phases>['check]: Remote test timeout.
>
> Change-Id: I535c72fec24658a4b2151d2e8794319055c9a278

[...]

> -                    (timeout "600")
>                      (jobs (if parallel-tests?
>                                (number->string (parallel-job-count))
>                                "1")))
> @@ -478,7 +477,6 @@ (define-public libtorrent-rasterbar
>                   (invoke "ctest"
>                           "-E" exclude-regex
>                           "-j" jobs
> -                         "--timeout" timeout

What’s the rationale though?

If we know that tests, individually, are meant to take less than 10mn,
it still seems nicer to stop at 10mn rather than wait for the 1h
max-silent timeout, no?

Thanks,
Ludo’.




  reply	other threads:[~2023-12-12  8:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-09  0:31 [bug#67722] [PATCH] gnu: libtorrent-rasterbar: Remove timeout for tests Tomas Volf
2023-12-09 19:34 ` [bug#67722] [PATCH v2] " Tomas Volf
2023-12-12  8:11   ` Ludovic Courtès [this message]
2023-12-12 23:03     ` Tomas Volf
2023-12-13 16:38 ` [bug#67722] [PATCH v3] gnu: libtorrent-rasterbar: Work around hang in test_ssl Tomas Volf
2023-12-15 11:32 ` [bug#67722] [PATCH v4] " Tomas Volf
2024-01-16 13:27   ` Tomas Volf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fs07263o.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=67722@debbugs.gnu.org \
    --cc=~@wolfsden.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.