From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: 17150@debbugs.gnu.org
Subject: bug#17150: Stale bootstrap/*/guile-2.0.9.tar.xz files are not detected
Date: Tue, 01 Apr 2014 11:50:08 +0200 [thread overview]
Message-ID: <87eh1hl6pb.fsf@gnu.org> (raw)
In-Reply-To: <87lhvqm179.fsf@yeeloong.lan> (Mark H. Weaver's message of "Mon, 31 Mar 2014 18:51:22 -0400")
Mark H Weaver <mhw@netris.org> skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> I just realized that my x86_64 and Loongson 3A systems have spent an
>>> enormous amount of time building the new guix master branch based on
>>> outdated bootstrap/*/guile-2.0.9.tar.xz.
>>>
>>> The issue is that if you simply "git pull" from a build directory with
>>> older versions of bootstrap/*/guile-2.0.9.tar.xz, although the various
>>> places where the hashes are stored are updated, those new hashes are
>>> never checked against the existing files. Therefore, you can proceed to
>>> build an entire system based on an outdated bootstrap guile, and with
>>> hashes that don't match what's on hydra and what other people are
>>> building.
>>
>> Right, ‘guix pull’ doesn’t survive updates of the bootstrap Guile
>> tarballs, because it doesn’t try to download it (see ‘build-guix’ in
>> guix/build/pull.scm.) That’s rare in practice, but still a serious
>> limitation as you note. :-/
>
> Hmm, yes, I suppose that "guix pull" is more relevant for typical users,
> but actually that's not what I was talking about above. I was talking
> about "git pull" followed by "make".
Ah, sorry! Ah yes, I see what the problem is. Only
build-aux/download.scm checks the hash, so indeed, if the file is stale
or modified later, Guix doesn’t notice.
Perhaps we should add a ‘check-hash’ rule or something in the makefile,
that automatically triggers before installation or something?
Ludo’.
prev parent reply other threads:[~2014-04-01 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 19:20 bug#17150: Stale bootstrap/*/guile-2.0.9.tar.xz files are not detected Mark H Weaver
2014-03-31 19:40 ` Mark H Weaver
2014-03-31 22:19 ` Ludovic Courtès
2014-03-31 22:51 ` Mark H Weaver
2014-04-01 9:50 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eh1hl6pb.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=17150@debbugs.gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.