all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice <me@tobias.gr>
To: guix-devel <guix-devel@gnu.org>
Subject: SSHv2 doesn't actually have compression levels
Date: Tue, 30 Jul 2019 03:58:32 +0200	[thread overview]
Message-ID: <87ef28fflj.fsf@nckx> (raw)

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

Guix,

While reading (guix scripts offload) in a (failed) attempt to get 
offloading working, the following comment caught my eye:

  ;; We rely on protocol-level compression from libssh to optimize 
  large data
  ;; transfers.  Warn if it's missing.

which means that we're not currently doing our own compression 
inside the tunnel.

This is significant, because it means that the COMPRESS-LEVEL 
field of BUILD-MACHINE is completely bogus[0], and probably always 
was - unless it once supported SSHv1, which I think we can agree 
is not something we want to support today.  Nobody's offloading 
libreoffice to that old router in the attic.

I'd like to undocument the option, and add a comment noting its 
lack of any useful effect to the code, by next week.

Kind regards,

T G-R

[0]: Take a look at OpenSSH's readconf.c, packet.c, and all calls 
to start_compression_out().

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

             reply	other threads:[~2019-07-30  1:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-30  1:58 Tobias Geerinckx-Rice [this message]
2019-08-22 21:48 ` SSHv2 doesn't actually have compression levels Ludovic Courtès
2019-08-22 22:00   ` Tobias Geerinckx-Rice
2019-08-23 12:21     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef28fflj.fsf@nckx \
    --to=me@tobias.gr \
    --cc=guix-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.