all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Christopher Baines <mail@cbaines.net>
Cc: 33517@debbugs.gnu.org
Subject: bug#33517: Problem booting when using btrfs subvolume for /gnu/store
Date: Thu, 26 Sep 2019 17:04:24 +0900	[thread overview]
Message-ID: <87ef03eb5j.fsf@gmail.com> (raw)
In-Reply-To: <875zwdqgtn.fsf@cbaines.net> (Christopher Baines's message of "Sat, 01 Dec 2018 17:48:04 +0000")

Hi Christopher,

Christopher Baines <mail@cbaines.net> writes:

> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello,
>>
>> Christopher Baines <mail@cbaines.net> skribis:
>>
>>> Unfortunately, it's not a proper solution, as it obviously breaks when
>>> you actually want to strip the mount point off so that grub can find the
>>> right files.
>>
>> Is there a way ‘strip-mount-point’ or some higher-level code could
>> determine whether we actually need to strip the mount point?
>
> So, this is the file-system value that I'm using currently for the
> store. The information about subvolume is in the options value.
>
> (file-system
>   (device (uuid "84fc6b78-d7ff-45df-8659-bef44b5bf0ea"))
>   (type "btrfs")
>   (title 'uuid)
>   (mount-point "/gnu/store")
>   (needed-for-boot? #t)
>   (options "subvol=/gnu/store"))

Ah, that subvolume name explains why your fix would work.  I was
confused at first why such fix should work.

Grub mounts the Btrfs partition at its 'top level'.  In Btrfs, the
subvolume names appear as directories under the top level, so in your
case not striping the mount-point amounts to prepending the subvolume
name to the "real" file path location (as it has the same value as the
mount-point).

That means that your fix only works when mount-point == subvol.

Maxim

  reply	other threads:[~2019-09-26  8:05 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-26 20:27 bug#33517: Problem booting when using btrfs subvolume for /gnu/store Christopher Baines
2018-11-28 13:21 ` Ludovic Courtès
2018-12-01 17:48   ` Christopher Baines
2019-09-26  8:04     ` Maxim Cournoyer [this message]
2019-01-26 23:59 ` Svante v. Erichsen
2019-02-03 14:41   ` david.larsson
2019-09-06  1:16   ` Maxim Cournoyer
2020-05-20 13:31 ` Maxim Cournoyer
2020-05-20 19:46   ` Christopher Baines
2020-05-21  1:34     ` Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ef03eb5j.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=33517@debbugs.gnu.org \
    --cc=mail@cbaines.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.