all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Tobias Geerinckx-Rice via Guix-patches via <guix-patches@gnu.org>
To: Felix Lechner <felix.lechner@lease-up.com>
Cc: guix-patches@gnu.org, 59623-done@debbugs.gnu.org
Subject: bug#59623: [PATCH] gnu: Add bgpq3.
Date: Fri, 02 Dec 2022 20:44:01 +0100	[thread overview]
Message-ID: <87edthy3uu.fsf@nckx> (raw)
In-Reply-To: <20221127022727.28672-1-felix.lechner@lease-up.com>

[-- Attachment #1: Type: text/plain, Size: 1897 bytes --]

Hi Felix,

Felix Lechner via Guix-patches via 写道:
> * gnu/packages/networking.scm (bgpq3): New variable.

Thanks!

> +(define-public bgpq3
> +  (let ((commit "9e46c66cff0c0cdcca653141b1664dbf6f9370ed")
> +        (revision "0"))

I dropped this and referred directly to the

> +      (version (git-version "0.1.36.1" revision commit))

tag, only because that's the current convention.  The result is 
equivalent.

> +      (arguments
> +       '(#:phases
> +         (modify-phases %standard-phases
> +           (delete 'check))))

Similarly, we use

  #:tests? #f                 ; no test suite

instead.  No functional change.

> +      (home-page "http://snar.spb.ru/prog/bgpq3/")

Self-signed certificates are the best certificates!  :-/

> +      (synopsis "Generate BGP filters from the Internet Routing 
> Registry system")
> +      (description
> +       "This program generates BGP routing filters from data in 
> the Internet
> +Routing Registry system, including the Routing Assets Database 
> that is operated
> +by the Merit Network at the University of Michigan.  Examples 
> are prefix-lists,
> +extended access-lists, policy-statement terms and as-path 
> lists.  It is an
> +essential peering tool for exchange operators.")

I took the liberty of expanding this a bit, mostly by adding 
mark-up and including the search terms ‘IRR’ and ‘RADB’.

I don't dispute its accuracy, but ‘an essential peering tool’ runs 
afoul of Guix's policy of toning down marketing language.  I did 
keep the reference to IXes though.

> +      (license license:bsd-2))))

As noted on IRC, there are two BSD-3 files in this package.  Both 
the author & GitHub seem to have missed this.  I've submitted a 
bug report.

Pushed with the above changes as 
9ef6286bc3f6ed780606d3c2089aed7ff73074c3.

Kind regards,

T G-R

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 247 bytes --]

      reply	other threads:[~2022-12-02 19:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-27  2:27 [bug#59623] [PATCH] gnu: Add bgpq3 Felix Lechner via Guix-patches via
2022-12-02 19:44 ` Tobias Geerinckx-Rice via Guix-patches via [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edthy3uu.fsf@nckx \
    --to=guix-patches@gnu.org \
    --cc=59623-done@debbugs.gnu.org \
    --cc=felix.lechner@lease-up.com \
    --cc=me@tobias.gr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.