From: ludo@gnu.org (Ludovic Courtès)
To: Cyril Roelandt <tipecaml@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 4/5] import: pypi: Compute test requirements when reading requirements files.
Date: Fri, 22 Jul 2016 23:30:37 +0200 [thread overview]
Message-ID: <87d1m5pdhe.fsf@gnu.org> (raw)
In-Reply-To: <1468682605-12622-5-git-send-email-tipecaml@gmail.com> (Cyril Roelandt's message of "Sat, 16 Jul 2016 17:23:24 +0200")
Cyril Roelandt <tipecaml@gmail.com> skribis:
> * guix/import/pypi.scm (guess-requirement-from-source): Read
> test-requirements.txt as well as requirements.txt.
> * tests/pypi.scm ("pypi->guix-package"): Update accordingly.
[...]
> (let* ((req-file (string-append dirname "/requirements.txt"))
> - (exit-code (system* "tar" "xf" tarball req-file)))
> + (test-req-file (string-append dirname "/test-requirements.txt"))
> + (exit-code (system* "tar" "xf" tarball req-file))
> + (test-exit-code (system* "tar" "xf" tarball test-req-file)))
> ;; TODO: support more formats.
> - (if (zero? exit-code)
> + (if (or (zero? exit-code)
> + (zero? test-exit-code))
This seems to suggest that this could be factorized somehow. Maybe
unpack once and read the two files at once?
Ludo’.
next prev parent reply other threads:[~2016-07-22 21:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-16 15:23 [PATCH 0/5] Improve the pypi updater Cyril Roelandt
2016-07-16 15:23 ` [PATCH 1/5] import: pypi: Move runtime dependencies to the propagated-inputs Cyril Roelandt
2016-07-16 15:23 ` [PATCH 2/5] import: pypi: Remove setuptools from the inputs Cyril Roelandt
2016-07-22 21:24 ` Ludovic Courtès
2016-07-22 21:43 ` Leo Famulari
2016-07-23 14:46 ` Cyril Roelandt
2016-07-25 21:07 ` Ludovic Courtès
2016-07-16 15:23 ` [PATCH 3/5] import: pypi: Compute test requirements when using wheels Cyril Roelandt
2016-07-22 21:28 ` Ludovic Courtès
2016-07-16 15:23 ` [PATCH 4/5] import: pypi: Compute test requirements when reading requirements files Cyril Roelandt
2016-07-22 21:30 ` Ludovic Courtès [this message]
2016-07-23 14:48 ` Cyril Roelandt
2016-07-25 21:12 ` Ludovic Courtès
2016-07-16 15:23 ` [PATCH 5/5] import: pypi: Add more tests Cyril Roelandt
2016-07-22 21:31 ` Ludovic Courtès
2016-07-17 16:30 ` [PATCH 0/5] Improve the pypi updater Hartmut Goebel
2016-07-22 21:22 ` Ludovic Courtès
2016-07-23 14:53 ` Cyril Roelandt
2016-07-25 21:14 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d1m5pdhe.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=tipecaml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.