all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Brett Gilio <brettg@posteo.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 34382-done@debbugs.gnu.org
Subject: [bug#34382] [PATCH 4/5] gnu: Add python-docstyle.
Date: Tue, 12 Feb 2019 18:51:27 -0600	[thread overview]
Message-ID: <87d0nwfr3k.fsf@posteo.net> (raw)
In-Reply-To: <87sgwsfxhb.fsf@gnu.org>


Ludovic Courtès writes:

> Brett Gilio <brettg@posteo.net> skribis:
>
>>>From 0b66f38dd41230611cad44181a81bda38e40619f Mon Sep 17 00:00:00 2001
>> From: Brett Gilio <brettg@posteo.net>
>> Date: Thu, 7 Feb 2019 22:04:52 -0600
>> Subject: [PATCH 4/5] gnu: Add python-docstyle.
>>
>> * gnu/packages/python-xyz.scm (python-docstyle): New variable.
>
> Pushed as well.
>
> This series ended up taking me more time than I thought.  :-)
> First the patches were sent in reverse order, which I only realized
> later.  Then each patch had tiny issues (indentation, inappropriate
> description, code duplication, etc.) that I ended up fixing because they
> looked tiny at first…
>
> Please pay more attention to these things in the future.
>
> Regardless, thank you for the patches!
>
> Ludo’.

This was my first patch series, so I appreciate your feedback to help me
make sure that I am doing this correct in the future!

Thank you as always

      parent reply	other threads:[~2019-02-13  0:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08  4:10 [bug#34382] [PATCH 4/5] gnu: Add python-docstyle Brett Gilio
2019-02-12 22:33 ` bug#34382: " Ludovic Courtès
2019-02-13  0:50   ` [bug#34382] " Brett Gilio
2019-02-13  0:51   ` Brett Gilio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d0nwfr3k.fsf@posteo.net \
    --to=brettg@posteo.net \
    --cc=34382-done@debbugs.gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.