From: Marius Bakke <mbakke@fastmail.com>
To: Jack Hill <jackhill@jackhill.us>, 34900-done@debbugs.gnu.org
Subject: bug#34900: Add emacs-semantic-refactor
Date: Thu, 21 Mar 2019 20:49:58 +0100 [thread overview]
Message-ID: <87d0mk0zyx.fsf@fastmail.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1903172247080.16784@marsh.hcoop.net>
[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]
Jack Hill <jackhill@jackhill.us> writes:
> Hi Guix,
>
> The attached patch adds the emacs-semantic-refactor package.
Thanks!
> When reviewing this patch some particular things to look out for/questions
> I have:
>
> 0) There are different sections in the (gnu packages emacs-xyz) module
> that are delineated by comments (e.g. Emacs Hacking, Web Browsing, and
> Miscellaneous). I've added the definition of emacs-semantic-refactor near
> the end of the file in the Miscellaneous section. I wonder if this is
> correct or if it should go in the Emacs Hacking section. Paredit, which
> would be used in similar scenarios to semantic-refactor is in the Emacs
> Hacking section.
I don't have a good answer, so I went with your initial approach.
> 1) The upstream source contains a number of animated gif files
> demonstrating usage in the srefactor-demos directory. I do not see a build
> process for these, and assume they were created by hand. Are we free to
> distribute these in Guix?
As long as they are free to use and redistribute (i.e. not under a
separate license), it should be okay for Guix. GIFs generally don't
come with build instructions :-)
> 2) semantic-refactor has an optional integration with projectile whose
> availability is checked for with (featurep 'projectile). I have not added
> projectile as an input or propagated-input. Is this OK?
Great! Optional dependencies are typically not propagated.
> 3) I'm still new to writing package definitions, so extra scrutiny is
> warranted, particularly for the synopsis and description.
I added a "This package provides a ..." prefix to the description to
provide a little more context for the prospective reader.
Pushed as ea4a1e5d0b13b5c548804ac854e6eb30c5149ce4, thank you!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2019-03-21 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 3:04 [bug#34900] Add emacs-semantic-refactor Jack Hill
2019-03-21 19:49 ` Marius Bakke [this message]
2019-03-21 20:05 ` Jack Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0mk0zyx.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=34900-done@debbugs.gnu.org \
--cc=jackhill@jackhill.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.