From: Marius Bakke <mbakke@fastmail.com>
To: "Jakub Kądziołka" <kuba@kadziolka.net>
Cc: 39192-done@debbugs.gnu.org
Subject: bug#39192: [PATCH] gnu: hexedit: Make F1 help more reliable
Date: Wed, 29 Jan 2020 11:08:14 +0100 [thread overview]
Message-ID: <87d0b2r2wh.fsf@devup.no> (raw)
In-Reply-To: <20200128073653.fvcvzitgphtuxzok@zdrowyportier.kadziolka.net>
[-- Attachment #1.1: Type: text/plain, Size: 1802 bytes --]
Jakub Kądziołka <kuba@kadziolka.net> writes:
> On Tue, Jan 28, 2020 at 12:36:04AM +0100, Marius Bakke wrote:
>> Jakub Kądziołka <kuba@kadziolka.net> writes:
>>
>> > * gnu/packages/hexedit.scm (hexedit)[arguments](patch-man-path): New
>> > phase.
>> > [inputs]: Add MAN-DB.
>>
>> While this change is harmless, I think we can generally expect "man" to
>> be available. Does the program crash if man-db is not installed? Or
>> does it print an actionable error message?
>>
>> In the latter case I'm inclined to leave things as-is, in the former
>> case let's patch it. But no strong opinion, mostly curious :-)
>
> Currently, the problem appears when hexedit is used in a `guix
> environment', and man-db is not specified as an input for the
> environment. In this case (assuming --pure hasn't been used), man prints
> an error message saying "no manpage for hexedit" when the user presses
> F1, but it cannot be seen until one exits hexedit. For a new user, this
> is not a trivial feat. Moreover, the error is confusing - it suggests
> that the manpage just hasn't been packaged.
Right. The problem of manpages being unavailable unless man-db is
included in the profile is not unique to hexedit. 'git foo --help' has
the same problem in a --pure environment. But at least then you get a
good error message.
> When man isn't found at all, no error message is printed, the F1 key
> just makes the screen blink. This could happen in a --pure environment.
I see, not great. Sounds like a good reason to add man-db as an input
in this case.
> In hindsight, this is something I should've explained in my first message.
> Sorry about that.
No worries, these things are difficult. :-)
Pushed in 602059e79, with a few cosmetic modifications:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: Type: text/x-patch, Size: 1551 bytes --]
diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm
index 368a902ce3..e1a029167a 100644
--- a/gnu/packages/hexedit.scm
+++ b/gnu/packages/hexedit.scm
@@ -49,20 +49,22 @@
`(#:tests? #f ; no check target
#:phases
(modify-phases %standard-phases
- ;; Make F1 open the man page even if man-db is not in the profile
+ ;; Make F1 open the man page even if man-db is not in the profile.
(add-after 'unpack 'patch-man-path
- (lambda _
+ (lambda* (#:key inputs outputs #:allow-other-keys)
(substitute* "interact.c"
(("\"man\"")
- (string-append "\"" (assoc-ref %build-inputs "man-db") "/bin/man\""))
+ (string-append "\"" (assoc-ref inputs "man-db") "/bin/man\""))
(("\"hexedit\"")
- (string-append "\"" (assoc-ref %outputs "out") "/share/man/man1/hexedit.1.gz\""))))))))
+ (string-append "\"" (assoc-ref outputs "out")
+ "/share/man/man1/hexedit.1.gz\"")))
+ #t)))))
(native-inputs
`(("autoconf" ,autoconf)
("automake" ,automake)))
(inputs
- `(("ncurses" ,ncurses)
- ("man-db" ,man-db)))
+ `(("man-db" ,man-db)
+ ("ncurses" ,ncurses)))
(synopsis "View and edit files or devices in hexadecimal or ASCII")
(description "hexedit shows a file both in ASCII and in hexadecimal. The
file can be a device as the file is read a piece at a time. You can modify
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
prev parent reply other threads:[~2020-01-29 10:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-19 12:44 [bug#39192] [PATCH] gnu: hexedit: Make F1 help more reliable Jakub Kądziołka
2020-01-27 23:36 ` Marius Bakke
2020-01-28 7:36 ` Jakub Kądziołka
2020-01-29 10:08 ` Marius Bakke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d0b2r2wh.fsf@devup.no \
--to=mbakke@fastmail.com \
--cc=39192-done@debbugs.gnu.org \
--cc=kuba@kadziolka.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.