From: Christopher Baines <mail@cbaines.net>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 43494@debbugs.gnu.org
Subject: [bug#43494] [PATCH 1/4] gnu: Add guix-build-coordinator.
Date: Sat, 19 Sep 2020 10:05:06 +0100 [thread overview]
Message-ID: <87d02i9lx9.fsf@cbaines.net> (raw)
In-Reply-To: <87lfh6vodj.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 2797 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hi!
>
> Christopher Baines <mail@cbaines.net> skribis:
>
>> * gnu/packages/package-management.scm (guix-build-coordinator): New variable.
>
> [...]
>
>> + (lambda* (#:key inputs outputs #:allow-other-keys)
>> + (let* ((out (assoc-ref outputs "out"))
>> + (bin (string-append out "/bin"))
>> + (guile (assoc-ref inputs "guile"))
>> + (guile-effective-version
>> + (read-line
>> + (open-pipe* OPEN_READ
>> + (string-append guile "/bin/guile")
>> + "-c" "(display (effective-version))")))
>
> Maybe use ‘target-guile-effective-version’ from (guix build
> guile-build-system).
I've changed this. I'll also try and remember and update the
guix-data-service package accordingly, as that's where I copied this
from.
>> + (wrap-program (string-append bin "/" file)
>> + `("PATH" ":" prefix
>> + (,bin ,(assoc-ref inputs "sqitch")))
>> + `("PERL5LIB" ":" prefix
>> + (,(getenv "PERL5LIB")))
>
> Do we really need PERL5LIB here? Shouldn’t it be done in the wrapper of
> ‘sqitch’ directly?
Hmm, when I packaged sqitch, I didn't add all the database drivers which
are optional dependencies, but perl-dbd-pg did end up in there somehow
(probably because that's needed by the guix-data-service).
I've now gone ahead and added the database drivers which Guix has
packages for [1], it does increase the closure size a bit, but it was
quite big anyway.
1:
http://git.savannah.gnu.org/cgit/guix.git/commit/?id=6a1c3a908c8aadfde5b5fe405132839683a01776
All that means I can remove the wrapping here.
>> + (scandir bin
>> + (match-lambda
>> + ((or "." "..") #f)
>> + (_ #t))))
>
> I think you could just use (find-files bin).
Done.
>> + (inputs
>> + `(("guile" ,guile-3.0-latest)
>
> Rather ,@(assoc-ref (package-native-inputs guix) "guile").
Done.
>> + ("sqitch" ,sqitch)
>> + ("perl-dbd-sqlite" ,perl-dbd-sqlite)))
>
> Shouldn’t perl-dbd-sqlite be a dependency of sqitch?
See above.
>> + (home-page "https://git.cbaines.net/guile/guix/build-coordinator")
>> + (synopsis "")
>> + (description
>> + "")
>
> Missing! :-)
Ah, yeah, I should have remembered to lint the package. I've attempted
to write something now, I'm still working on trying to explain what the
Guix Build Coordinator is meant to be.
> LGTM with changes along these lines!
Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]
next prev parent reply other threads:[~2020-09-19 9:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-18 18:34 [bug#43494] [PATCH 0/4] Add package and services for the Guix Build Coordinator Christopher Baines
2020-09-18 18:40 ` [bug#43494] [PATCH 1/4] gnu: Add guix-build-coordinator Christopher Baines
2020-09-18 18:40 ` [bug#43494] [PATCH 2/4] services: guix: Add guix-build-coordinator-service-type Christopher Baines
2020-09-18 20:20 ` Ludovic Courtès
2020-09-19 9:13 ` Christopher Baines
2020-09-25 9:42 ` Ludovic Courtès
2020-09-26 8:43 ` Christopher Baines
2020-09-18 18:40 ` [bug#43494] [PATCH 3/4] services: guix: Add guix-build-coordinator-agent-service-type Christopher Baines
2020-09-18 20:25 ` Ludovic Courtès
2020-09-19 9:49 ` Christopher Baines
2020-09-18 18:40 ` [bug#43494] [PATCH 4/4] services: guix: Add guix-build-coordinator-queue-builds-service-type Christopher Baines
2020-09-18 20:31 ` Ludovic Courtès
2020-09-19 10:05 ` Christopher Baines
2020-09-18 20:08 ` [bug#43494] [PATCH 1/4] gnu: Add guix-build-coordinator Ludovic Courtès
2020-09-18 23:34 ` Jonathan Brielmaier
2020-09-19 9:00 ` Christopher Baines
2020-09-19 9:05 ` Christopher Baines [this message]
2020-09-19 10:10 ` [bug#43494] [PATCH v2 " Christopher Baines
2020-09-19 10:10 ` [bug#43494] [PATCH v2 2/4] services: guix: Add guix-build-coordinator-service-type Christopher Baines
2020-09-19 10:10 ` [bug#43494] [PATCH v2 3/4] services: guix: Add guix-build-coordinator-agent-service-type Christopher Baines
2020-09-19 10:10 ` [bug#43494] [PATCH v2 4/4] services: guix: Add guix-build-coordinator-queue-builds-service-type Christopher Baines
2020-10-05 8:00 ` Ludovic Courtès
2020-10-05 17:16 ` bug#43494: " Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d02i9lx9.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=43494@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.