From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: 43635@debbugs.gnu.org
Cc: 43635-done@debbugs.gnu.org, Adam Kandur <rndd@tuta.io>
Subject: [bug#43635] hope, this is right
Date: Thu, 01 Oct 2020 15:42:17 +0200 [thread overview]
Message-ID: <87d02212rq.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <MIEhhbb--B-2@tuta.io> (Adam Kandur via Guix-patches via's message of "Sun, 27 Sep 2020 15:18:22 +0200 (CEST)")
Hello,
Adam Kandur via Guix-patches via <guix-patches@gnu.org> writes:
> Subject: [PATCH] gnu: Add emacs-sqlite.el
Thank you. I applied your patch with the changes detailed below.
> + (let ((commit "dad42b8bbca4994be1871343dd18fd6528ee5797") ;; there is no tagged commit
> + (revision "0"))
I moved the comment on the line above since comments starting with two
semicolons are expected to stand by their own line.
> + (package
> + (name "emacs-sqlite.el")
I changed the name to "emacs-sqlite". Ditto for the name of the variable.
> + (synopsis "SQLite Interface for Emas Lisp")
I fixed the type and changed case for "Interface".
> + (description "@code{sqlite.el} is a simple SqliteInterface for connecting and retrieving
> +information using the SQLite program through Elisp programming. It
> is not intended as a user interface.")
I fixed spacing and renamed the package.
I also moved the package elsewhere, since adding a package at the end of
the file is more likely to cause merge conflicts.
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2020-10-01 13:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-26 20:36 [bug#43635] [PATCH] gnu: Add emacs-sqlite Adam Kandur via Guix-patches via
2020-09-27 12:31 ` Nicolas Goaziou
2020-09-27 13:18 ` [bug#43635] hope, this is right Adam Kandur via Guix-patches via
2020-10-01 13:42 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d02212rq.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=43635-done@debbugs.gnu.org \
--cc=43635@debbugs.gnu.org \
--cc=rndd@tuta.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.