From: "Ludovic Courtès" <ludo@gnu.org>
To: Mathieu Othacehe <othacehe@gnu.org>
Cc: 45018@debbugs.gnu.org
Subject: [bug#45018] [PATCH 2/6] daemon: Use 'Agent' to spawn 'guix substitute --query'.
Date: Sun, 06 Dec 2020 22:51:26 +0100 [thread overview]
Message-ID: <87czzm4n8h.fsf@gnu.org> (raw)
In-Reply-To: <87wnxynfni.fsf@gnu.org> (Mathieu Othacehe's message of "Fri, 04 Dec 2020 09:23:29 +0100")
Mathieu Othacehe <othacehe@gnu.org> skribis:
>> + (("--substitute" store-path destination)
>> + ;; Download STORE-PATH and add store it as a Nar in file DESTINATION.
>
> add it to store?
Oops.
>> + const Strings args = { "substitute", "--query" };
>> + const std::map<string, string> env = { { "_NIX_OPTIONS", settings.pack() } };
>> + std::unique_ptr<Agent>fresh(new Agent(settings.guixProgram, args, env));
>
> You should prefer make_unique to "new" calls.
Apparently ‘make_unique’ is a C++14 thing and we don’t build against
that standard (yet), so I left it as is. The next patch removes this
use of ‘unique_ptr’ anyway.
next prev parent reply other threads:[~2020-12-06 21:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 10:13 [bug#45018] [PATCH 0/6] Process and connection reuse for substitutions Ludovic Courtès
2020-12-03 10:19 ` [bug#45018] [PATCH 1/6] daemon: 'Agent' constructor takes a list of environment variables Ludovic Courtès
2020-12-03 10:19 ` [bug#45018] [PATCH 2/6] daemon: Use 'Agent' to spawn 'guix substitute --query' Ludovic Courtès
2020-12-04 8:23 ` Mathieu Othacehe
2020-12-06 21:51 ` Ludovic Courtès [this message]
2020-12-03 10:19 ` [bug#45018] [PATCH 3/6] daemon: Factorize substituter agent spawning Ludovic Courtès
2020-12-04 8:19 ` Mathieu Othacehe
2020-12-03 10:19 ` [bug#45018] [PATCH 4/6] daemon: Run 'guix substitute --substitute' as an agent Ludovic Courtès
2020-12-04 8:27 ` Mathieu Othacehe
2020-12-06 21:53 ` Ludovic Courtès
2020-12-03 10:19 ` [bug#45018] [PATCH 5/6] substitute: Cache and reuse connections while substituting Ludovic Courtès
2020-12-03 10:19 ` [bug#45018] [PATCH 6/6] daemon: Raise an error if substituter doesn't send the expected hash Ludovic Courtès
2020-12-03 11:48 ` [bug#45018] [PATCH 0/6] Process and connection reuse for substitutions 宋文武
2020-12-03 20:52 ` Ludovic Courtès
2020-12-04 8:34 ` Mathieu Othacehe
2020-12-06 22:04 ` [bug#45018] [PATCH v2 " Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 1/6] daemon: 'Agent' constructor takes a list of environment variables Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 2/6] daemon: Use 'Agent' to spawn 'guix substitute --query' Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 3/6] daemon: Factorize substituter agent spawning Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 4/6] daemon: Run 'guix substitute --substitute' as an agent Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 5/6] substitute: Cache and reuse connections while substituting Ludovic Courtès
2020-12-06 22:04 ` [bug#45018] [PATCH v2 6/6] daemon: Raise an error if substituter doesn't send the expected hash Ludovic Courtès
2020-12-08 22:39 ` bug#45018: [PATCH v2 0/6] Process and connection reuse for substitutions Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czzm4n8h.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=45018@debbugs.gnu.org \
--cc=othacehe@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.