all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: guix-devel@gnu.org, Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: Re: 03/163: build/python: Add a new guix-pythonpath procedure.
Date: Mon, 25 Jan 2021 22:46:33 +0100	[thread overview]
Message-ID: <87czxs3d1i.fsf@gnu.org> (raw)
In-Reply-To: <20210125070114.03C0B20E1C@vcs0.savannah.gnu.org> (guix-commits@gnu.org's message of "Mon, 25 Jan 2021 02:01:13 -0500 (EST)")

Hi!

guix-commits@gnu.org skribis:

> apteryx pushed a commit to branch cu/farewell-to-pythonpath
> in repository guix.

Woow!

> commit c3c5bdd2b0ea4588ecba424fdbf6df101d967d3d
> Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
> AuthorDate: Fri Jan 22 09:34:33 2021 -0500
>
>     build/python: Add a new guix-pythonpath procedure.
>     
>     This procedure will be used in place where the static "PYTHONPATH" string used
>     to be.
>     
>     * guix/build/python-build-system.scm (guix-pythonpath): New procedure.

[...]

> +(define (guix-pythonpath inputs)
> +  "Derive the GUIX_PYTHONPATH_X_Y string , with the major and minor version
> +numbers substituted for X and Y, respectively."
> +  (let ((python (assoc-ref inputs "python")))
> +    (string-append "GUIX_PYTHONPATH_"
> +                   (string-replace-substring (python-version python) "." "_"))))

One pattern used elsewhere, notably for ‘GUIX_LOCPATH’, is to still keep
a single environment variable (that’d be ‘GUIX_PYTHONPATH’ here) but to
ensure that only MAJOR.MINOR sub-directories are taken into
consideration.

IOW, instead of having GUIX_PYTHONPATH_3_8 and GUIX_PYTHONPATH_2_7,
you’d have just GUIX_PYTHONPATH but Python 3.8 would only care about
3.8/ sub-directories while 2.7 would only care about 2.7/
sub-directories.

That’s perhaps easier to document and to deal with generally (you only
need to look at one specific environment variable).

Does that make sense?  I don’t know if it’s applicable in this case
though.

(I didn’t follow the PYTHONPATH discussion so apologies if this comment
is off!)

Anyhow, thanks for this long awaited change!

Ludo’.


       reply	other threads:[~2021-01-25 21:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210125070022.22870.17321@vcs0.savannah.gnu.org>
     [not found] ` <20210125070114.03C0B20E1C@vcs0.savannah.gnu.org>
2021-01-25 21:46   ` Ludovic Courtès [this message]
2021-01-25 22:10     ` 03/163: build/python: Add a new guix-pythonpath procedure Maxim Cournoyer
2021-01-28 14:16       ` Ludovic Courtès
2021-01-29 14:25         ` Maxim Cournoyer
2021-02-01 15:37           ` Ludovic Courtès
2021-02-05 10:26           ` Hartmut Goebel
2021-02-26 15:36             ` Maxim Cournoyer
2021-03-07 11:13               ` Hartmut Goebel
2021-03-14  0:58                 ` Maxim Cournoyer
2021-03-27 10:47                   ` Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czxs3d1i.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guix-devel@gnu.org \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.