all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ben Sturmfels via Guix-patches via <guix-patches@gnu.org>
To: 47210@debbugs.gnu.org
Subject: [bug#47210] Enable ogg/flac/vorbis/opus support in libsndfile
Date: Wed, 17 Mar 2021 21:50:44 +1100	[thread overview]
Message-ID: <87czvy12bf.fsf@sturm.com.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]

Hi folks,

This is small update to libsndfile as part of my effort to package
MediaGoblin. Essentially, the ogg/flac/vorbis/opus support is only on if
*all four* libraries are present, and opus is currently missing.

Before applying this patch, the configure phase for libsndfile reports:

  checking for flac >= 1.3.1 ... yes
  checking for ogg >= 1.3.0 ... yes
  checking for vorbis >= 1.2.3 ... yes
  checking for vorbisenc >= 1.2.3 ... yes
  checking for opus >= 1.1 ... no           <<< LOOK HERE

  configure: WARNING: *** One or more of the external libraries (ie libflac, libogg and
  configure: WARNING: *** libvorbis) is either missing (possibly only the development
  configure: WARNING: *** headers) or is of an unsupported version.
  configure: WARNING: ***
  configure: WARNING: *** Unfortunately, for ease of maintenance, the external libs
  configure: WARNING: *** are an all or nothing affair.

  -=-=-=-=-=-=-=-=-=-= Configuration Complete =-=-=-=-=-=-=-=-=-=-=-

    Configuration summary :

      External FLAC/Ogg/Vorbis/Opus : ....... no


After this patch the libsndfile configure shows:

  checking for flac >= 1.3.1 ... yes
  checking for ogg >= 1.3.0 ... yes
  checking for vorbis >= 1.2.3 ... yes
  checking for vorbisenc >= 1.2.3 ... yes
  checking for opus >= 1.1 ... yes         <<< LOOK HERE

  -=-=-=-=-=-=-=-=-=-= Configuration Complete =-=-=-=-=-=-=-=-=-=-=-

    Configuration summary :

      External FLAC/Ogg/Vorbis/Opus : ....... yes


Regards,
Ben

Ben Sturmfels

Sturm Software Engineering
www.sturm.com.au
+61 3 9024 2467

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-libsndfile-enable-vorbis-ogg-flac-opus-support.patch --]
[-- Type: text/x-patch, Size: 861 bytes --]

From d91cedcdd324d10d0406166c43b938cba842eb03 Mon Sep 17 00:00:00 2001
From: Ben Sturmfels <ben@sturm.com.au>
Date: Wed, 17 Mar 2021 21:35:16 +1100
Subject: [PATCH] gnu: libsndfile: enable vorbis/ogg/flac/opus support.

* gnu/packages/pulseaudio.scm (libsndfile): Add input for opus to trigger
all-or-nothing external library support
---
 gnu/packages/pulseaudio.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index ea61dd807c..0c1acdc6e0 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -102,7 +102,8 @@
     (inputs
      `(("libvorbis" ,libvorbis)
        ("libogg" ,libogg)
-       ("flac" ,flac)))
+       ("flac" ,flac)
+       ("opus" ,opus)))
     (native-inputs
      `(("pkg-config" ,pkg-config)
        ("python" ,python)))
-- 
2.30.2


             reply	other threads:[~2021-03-17 10:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17 10:50 Ben Sturmfels via Guix-patches via [this message]
2021-03-17 11:35 ` [bug#47210] Enable ogg/flac/vorbis/opus support in libsndfile Ben Sturmfels via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czvy12bf.fsf@sturm.com.au \
    --to=guix-patches@gnu.org \
    --cc=47210@debbugs.gnu.org \
    --cc=ben@sturm.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.