all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: Thiago Jung Bauermann <bauermann@kolabnow.com>
Cc: 50326@debbugs.gnu.org
Subject: [bug#50326] [PATCH cuirass] Add systemd unit file for remote worker service.
Date: Wed, 08 Sep 2021 16:01:06 +0200	[thread overview]
Message-ID: <87czpj2ml9.fsf@gnu.org> (raw)
In-Reply-To: <20210901191443.59352-1-bauermann@kolabnow.com> (Thiago Jung Bauermann's message of "Wed, 1 Sep 2021 16:14:43 -0300")

Hello!

Thiago Jung Bauermann <bauermann@kolabnow.com> skribis:

> * etc/cuirass-remote-worker.service.in: New file.
> * doc/cuirass.texi: Mention it.
> * .gitignore: Ignore it.
> * Makefile.am (noinst_SCRIPTS): Add ‘etc/cuirass-remote-worker.service’.
> (EXTRA_DIST): Likewise.
> (etc/cuirass-remote-worker.service): New target.
> * configure.ac: Check for ‘(guix config)’ module.
> Set ‘guix_localstatedir’ variable.
> ---
>
> Hello,
>
> This patch adds the systemd unit file I installed on guixp9. The
> configure script finds out Guix’s localstatedir and substitutes it in
> etc/cuirass-remote-worker.service.in. The service file isn’t installed
> anywhere and the user is supposed to get it from the build directory if
> they want to use it.
>
> I did it this way because there’s no $PREFIX/doc/examples directory
> or equivalent where it could be shipped, and I thought that it would
> be excessive to add it to all Cuirass installations considering that
> only a few of them would actually have a use for it. But I can send a
> v2 making this change if people think it would be better.

With this approach, the user has to get the source and configure it,
which is somewhat annoying.

I’d prefer installing it to $sysconfdir, similar to how we do it in
Guix.  That makes it easier for interested users to locate the right
.service and to install it, right after they’ve done ‘guix install
cuirass’.

WDYT?

If that’s fine with you, I’ll happily push v2 on your behalf!

Thanks,
Ludo’.




  reply	other threads:[~2021-09-08 14:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-01 19:14 [bug#50326] [PATCH cuirass] Add systemd unit file for remote worker service Thiago Jung Bauermann via Guix-patches via
2021-09-08 14:01 ` Ludovic Courtès [this message]
2021-09-08 14:24   ` Thiago Jung Bauermann via Guix-patches via
2021-09-16  2:38   ` [bug#50326] [PATCH cuirass v2] " Thiago Jung Bauermann via Guix-patches via
2021-09-16 20:04     ` bug#50326: " Ludovic Courtès
2021-09-16 20:17       ` [bug#50326] " Thiago Jung Bauermann via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87czpj2ml9.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=50326@debbugs.gnu.org \
    --cc=bauermann@kolabnow.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.