From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: Lars-Dominik Braun <lars@6xq.net>, 52269@debbugs.gnu.org
Subject: bug#52269: [core-updates-frozen] sitecustomize.py does not honor .pth files
Date: Mon, 13 Dec 2021 09:10:38 -0500 [thread overview]
Message-ID: <87czm0y4rl.fsf@gmail.com> (raw)
In-Reply-To: <875yrs3jb7.fsf_-_@gnu.org> ("Ludovic Courtès"'s message of "Mon, 13 Dec 2021 11:12:12 +0100")
Hi Ludovic,
Ludovic Courtès <ludo@gnu.org> writes:
> Hello Maxim,
>
> Maxim Cournoyer <maxim.cournoyer@gmail.com> skribis:
>
>>>From 762357609270ab016236d22999ae5cfc3fe4ff28 Mon Sep 17 00:00:00 2001
>> From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
>> Date: Fri, 3 Dec 2021 22:36:26 -0500
>> Subject: [PATCH] sitecustomize.py: Honor .pth files.
>>
>> Fixes <https://issues.guix.gnu.org/52269>.
>>
>> * gnu/packages/aux-files/python/sitecustomize.py: Use site.addsitedirs to add
>> the site directories; this takes care of the .pth files. Make sure the added
>> items still appear before Python's own 'site-packages' directory.
>
> I had completely overlooked this patch.
>
> Lars had useful comments about it.
>
> Do we need to address this before we merge ‘core-updates-frozen’ into
> ‘master’?
The only reason I'm on the fence about it is that it causes a big
rebuild. But rebuilding aside, I believe it'd be nice to have it in.
I've only spotted one package affected so far (python-pdbpp), but there
may be others.
> If so, what changes need to be made to the patch before it can be
> applied?
I'll try having a look today.
Thanks,
Maxim
next prev parent reply other threads:[~2021-12-13 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 2:59 bug#52269: [core-updates-frozen] Some Python packages relying on .pth are broken Maxim Cournoyer
2021-12-04 5:36 ` bug#52269: [PATCH core-updates-frozen] sitecustomize does not honor .pth files Maxim Cournoyer
2021-12-13 10:12 ` bug#52269: [core-updates-frozen] sitecustomize.py " Ludovic Courtès
2021-12-13 14:10 ` Maxim Cournoyer [this message]
2021-12-06 8:42 ` bug#52269: [PATCH] sitecustomize.py: Honor " Lars-Dominik Braun
2021-12-13 19:04 ` bug#52269: [core-updates-frozen] sitecustomize.py does not honor " Maxim Cournoyer
2021-12-16 9:48 ` Lars-Dominik Braun
2021-12-17 14:41 ` Maxim Cournoyer
2021-12-17 15:02 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czm0y4rl.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=52269@debbugs.gnu.org \
--cc=lars@6xq.net \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.