From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: John Kehayias <john.kehayias@protonmail.com>
Cc: "53015@debbugs.gnu.org" <53015@debbugs.gnu.org>,
Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: [bug#53015] [PATCH 0/4] Add mangohud (update dear-imgui)
Date: Sun, 20 Feb 2022 23:11:54 -0500 [thread overview]
Message-ID: <87czjgq2np.fsf_-_@gmail.com> (raw)
In-Reply-To: <20wqWzWXCQm8C64APXWiUBQfFY0dYThLJMM9eoq7iiTvAoYra7wo97BUbAZwwW8O8PUdY5JNx_7gdA6QIAv-x6-dU3QsnkXKGW7V6mJjpaY=@protonmail.com> (John Kehayias's message of "Sat, 22 Jan 2022 05:06:17 +0000")
Hi John,
John Kehayias <john.kehayias@protonmail.com> writes:
> Hello,
>
> This patch (2/4 build option for spdlog, part of the MangoHud patch
> series) may be superseded by
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=b1542d59606919d0da04914fa6916b85354e2f89
> (CCing Nicolas, hope that's okay!) I've built MangoHud with the shared
> spdlog before, seems to work.
That should solve the problem, yes!
> However, given what spdlog has in its documentation, I wonder if it
> would be better to default to the static version as before? I think
> the "-fpic" build option would also work for shared linking in
> general? Or does that not work for nheko, which this change was for I
> believe?
Do you mean this:
https://github.com/gabime/spdlog/wiki/How-to-use-spdlog-in-DLLs ?
> I'm not really sure though, nor have a strong opinion, just going
> based on spdlog's info and that some projects (like MangoHud) build
> spdlog as a static library by default when bundling. I'm guessing it
> is for performance reasons, though I don't know if that is realized.
Typically in Guix the libraries are offered as shared objects by
default; and when desirable a static output can be added to which the
static objects are copied.
You could add a static output if you have such a need :-).
Maxim
next prev parent reply other threads:[~2022-02-21 4:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-04 22:20 [bug#53015] [PATCH 0/4] Add mangohud (update dear-imgui) John Kehayias via Guix-patches via
2022-01-04 22:23 ` [bug#53015] [PATCH 1/4] gnu: Add pciutils-no-zlib John Kehayias via Guix-patches via
2022-01-04 22:24 ` [bug#53015] [PATCH 2/4] gnu: spdlog: Build with '-fpic' John Kehayias via Guix-patches via
2022-01-22 5:06 ` John Kehayias via Guix-patches via
2022-02-21 4:11 ` Maxim Cournoyer [this message]
2022-02-21 16:36 ` [bug#53015] [PATCH 0/4] Add mangohud (update dear-imgui) John Kehayias via Guix-patches via
2022-02-21 17:31 ` Maxim Cournoyer
2022-01-04 22:25 ` [bug#53015] [PATCH 3/4] gnu: dear-imgui: Update to 1.81, hide version 1.79 John Kehayias via Guix-patches via
2022-01-04 22:34 ` [bug#53015] [PATCH 4/4] gnu: Add mangohud John Kehayias via Guix-patches via
2022-02-16 1:48 ` [bug#53015] [PATCH 0/4] Add mangohud (update dear-imgui) John Kehayias via Guix-patches via
2022-02-23 22:35 ` [bug#53015] [PATCH v2] Add mangohud John Kehayias via Guix-patches via
2022-02-27 1:14 ` [bug#53015] [PATCH v3] " John Kehayias via Guix-patches via
2022-02-27 2:31 ` Maxim Cournoyer
2022-02-27 4:31 ` John Kehayias via Guix-patches via
2022-03-02 1:37 ` [bug#53015] [PATCH 0/4] Add mangohud (update dear-imgui) Brendan Tildesley
2022-03-02 4:54 ` John Kehayias via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87czjgq2np.fsf_-_@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=53015@debbugs.gnu.org \
--cc=john.kehayias@protonmail.com \
--cc=mail@nicolasgoaziou.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.