all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Thiago Jung Bauermann <bauermann@kolabnow.com>
Cc: 59253@debbugs.gnu.org, liliana.prikler@gmail.com,
	Maxim Cournoyer <maxim.cournoyer@gmail.com>
Subject: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path.
Date: Mon, 14 Nov 2022 19:52:36 -0500	[thread overview]
Message-ID: <87cz9pvy23.fsf@kyleam.com> (raw)
In-Reply-To: <87h6z2p6jc.fsf@kolabnow.com>

Thiago Jung Bauermann via Guix-patches via writes:

> Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
[...]
>> Won't this make magit unusable from TRAMP (which already seems broken
>> for me since the time we enabled native comp -- anyone else?).
>
> Hm, interesting point. I don't know. I don't use TRAMP because it was
> too slow for me in the couple of times I've tried.
>
> magit/lisp/magit-git.el does have this custom variable though, which
> this patch didn't change:
>
> #+BEGIN_SRC elisp
> (defcustom magit-remote-git-executable "git"
>   "The Git executable used by Magit on remote machines.
> On the local host `magit-git-executable' is used instead.
> Consider customizing `tramp-remote-path' instead of this
> option."
>   :package-version '(magit . "3.2.0")
>   :group 'magit-process
>   :type 'string)
> #+END_SRC elisp
>
> So I'd say it's possible that my patch doesn't affect whether Magit
> works from TRAMP…

That's right.  magit-remote-git-executable is the executable that will
be used when operating remotely via TRAMP, so your patch shouldn't
affect it (and if it does, it's unintended behavior on Magit's end).

Note that, as the :package-version value suggests, this split happened
in a relatively recent release, so previous some previous discussions on
the list (e.g., bug#30434) are now out of date.




  reply	other threads:[~2022-11-15  1:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-13 21:11 [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path Thiago Jung Bauermann via Guix-patches via
2022-11-13 21:24 ` Liliana Marie Prikler
2022-11-13 21:55   ` bug#59253: " Liliana Marie Prikler
2022-11-13 22:21     ` [bug#59253] " Thiago Jung Bauermann via Guix-patches via
2022-11-14  3:01       ` Maxim Cournoyer
2022-11-14  3:09         ` Thiago Jung Bauermann via Guix-patches via
2022-11-15  0:52           ` Kyle Meyer [this message]
2022-11-15  4:30             ` Thiago Jung Bauermann via Guix-patches via
2022-11-15 13:49             ` Maxim Cournoyer
2022-11-15  8:52         ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz9pvy23.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=59253@debbugs.gnu.org \
    --cc=bauermann@kolabnow.com \
    --cc=liliana.prikler@gmail.com \
    --cc=maxim.cournoyer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.