From: Thiago Jung Bauermann via Guix-patches via <guix-patches@gnu.org>
To: Maxim Cournoyer <maxim.cournoyer@gmail.com>
Cc: liliana.prikler@gmail.com, 59253@debbugs.gnu.org,
59253-done@debbugs.gnu.org
Subject: [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path.
Date: Mon, 14 Nov 2022 00:09:21 -0300 [thread overview]
Message-ID: <87h6z2p6jc.fsf@kolabnow.com> (raw)
In-Reply-To: <87y1seqlwm.fsf@gmail.com>
Hello Maxim,
Maxim Cournoyer <maxim.cournoyer@gmail.com> writes:
> Hi,
>
> Thiago Jung Bauermann via Guix-patches via <guix-patches@gnu.org>
> writes:
>
>> Hello Liliana,
>>
>> Liliana Marie Prikler <liliana.prikler@gmail.com> writes:
>>
>>> Am Sonntag, dem 13.11.2022 um 22:24 +0100 schrieb Liliana Marie
>>> Prikler:
>>>> Am Sonntag, dem 13.11.2022 um 18:11 -0300 schrieb Thiago Jung
>>>> Bauermann:
>>>> > Magit has a strong dependency on Git so it should directly
>>>> > reference
>>>> > the
>>>> > git executable rather than expect it to be available in the profile
>>>> > or
>>>> > environment.
>>>> >
>>>> > This also fixes a build failure in emacs-forge.
>>>> >
>>>> > * gnu/packages/emacs-xyz.scm (emacs-magit)[arguments]<#:phases>:
>>>> > Substitute
>>>> > git path in the ‘magit-git-executable’ variable.
>>>> LGTM, will push once I'm done with some other stuff.
>>> Aaaand it's done.
>>
>> Wow, that was quick. Thank you!
>
> Won't this make magit unusable from TRAMP (which already seems broken
> for me since the time we enabled native comp -- anyone else?).
Hm, interesting point. I don't know. I don't use TRAMP because it was
too slow for me in the couple of times I've tried.
magit/lisp/magit-git.el does have this custom variable though, which
this patch didn't change:
#+BEGIN_SRC elisp
(defcustom magit-remote-git-executable "git"
"The Git executable used by Magit on remote machines.
On the local host `magit-git-executable' is used instead.
Consider customizing `tramp-remote-path' instead of this
option."
:package-version '(magit . "3.2.0")
:group 'magit-process
:type 'string)
#+END_SRC elisp
So I'd say it's possible that my patch doesn't affect whether Magit
works from TRAMP…
--
Thanks
Thiago
next prev parent reply other threads:[~2022-11-15 0:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-13 21:11 [bug#59253] [PATCH] gnu: emacs-magit: Substitute git executable path Thiago Jung Bauermann via Guix-patches via
2022-11-13 21:24 ` Liliana Marie Prikler
2022-11-13 21:55 ` bug#59253: " Liliana Marie Prikler
2022-11-13 22:21 ` [bug#59253] " Thiago Jung Bauermann via Guix-patches via
2022-11-14 3:01 ` Maxim Cournoyer
2022-11-14 3:09 ` Thiago Jung Bauermann via Guix-patches via [this message]
2022-11-15 0:52 ` Kyle Meyer
2022-11-15 4:30 ` Thiago Jung Bauermann via Guix-patches via
2022-11-15 13:49 ` Maxim Cournoyer
2022-11-15 8:52 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6z2p6jc.fsf@kolabnow.com \
--to=guix-patches@gnu.org \
--cc=59253-done@debbugs.gnu.org \
--cc=59253@debbugs.gnu.org \
--cc=bauermann@kolabnow.com \
--cc=liliana.prikler@gmail.com \
--cc=maxim.cournoyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).