From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: "Josselin Poiret" <dev@jpoiret.xyz>,
"Tobias Geerinckx-Rice" <me@tobias.gr>,
"Simon Tournier" <zimon.toutoune@gmail.com>,
"Mathieu Othacehe" <othacehe@gnu.org>,
"Ludovic Courtès" <ludo@gnu.org>,
"Christopher Baines" <mail@cbaines.net>,
60218@debbugs.gnu.org
Subject: [bug#60218] [PATCH 1/2] teams: Add a "get-maintainer" command.
Date: Mon, 26 Dec 2022 22:19:43 -0500 [thread overview]
Message-ID: <87cz858re8.fsf@gmail.com> (raw)
In-Reply-To: <87tu1kbd43.fsf@elephly.net> (Ricardo Wurmus's message of "Sun, 25 Dec 2022 00:15:39 +0100")
Hi Ricardo,
Ricardo Wurmus <rekado@elephly.net> writes:
> Hi Maxim,
>
>> This can be used as a compatibility mode with the get_maintainer.pl Perl
>> script included in the Linux (or U-Boot) source tree.
>>
>> * etc/teams.scm.in (git-patch->commit-id): New procedure.
>> (main) <get-maintainer>: Register new command. Document it.
>
> Interesting.
>
>> @@ -616,6 +627,14 @@ (define (main . args)
>> (("cc-members" rev-start rev-end)
>> (apply cc (find-team-by-scope
>> (diff-revisions rev-start rev-end))))
>> + (("get-maintainer" patch-file)
>> + (let* ((rev-end (git-patch->commit-id patch-file))
>> + (rev-start (string-append rev-end "^")))
>
> This is to get the changes introduced by this patch-file right? In a
> format that allows you to use “diff-revisions” below, which you need to
> run find-team-by-scope.
Yes! The get-maintainer.pl script expects a single patch file rather
than two git refspecs.
>> + (apply main "list-members"
>> + (map symbol->string
>> + (map team-id
>> + (find-team-by-scope
>> + (diff-revisions rev-start rev-end)))))))
>
> Here I’d do
>
> (map (compose symbol->string team-id) …)
>
> instead of mapping twice.
Thanks, that's better. Adjusted locally.
> I haven’t used get_maintainer.pl before, but I don’t object to this
> change if it’s useful to you.
It's useful in conjunction with patman (which is patch 2/2 of this
series), which can be configured to use a get-maintainer like script to
retrieve the people it should CC based on the patches it can 'git
send-email' for you. If nobody else has a say, I'll push in about a
week.
Thanks for taking a look!
--
Maxim
next prev parent reply other threads:[~2022-12-27 3:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 13:58 [bug#60218] [PATCH 0/2] New teams.scm 'get-maintainer' command (for integration with patman) Maxim Cournoyer
2022-12-20 14:13 ` [bug#60218] [PATCH 1/2] teams: Add a "get-maintainer" command Maxim Cournoyer
2022-12-20 14:13 ` [bug#60218] [PATCH 2/2] .patman: New configuration file Maxim Cournoyer
2022-12-24 23:15 ` [bug#60218] [PATCH 1/2] teams: Add a "get-maintainer" command Ricardo Wurmus
2022-12-27 3:19 ` Maxim Cournoyer [this message]
2022-12-27 10:00 ` [bug#60218] [PATCH 0/2] New teams.scm 'get-maintainer' command (for integration with patman) Mathieu Othacehe
2022-12-27 15:35 ` Maxim Cournoyer
2022-12-28 17:22 ` Mathieu Othacehe
2022-12-28 20:42 ` bug#60218: " Maxim Cournoyer
2022-12-27 15:32 ` [bug#60218] [PATCH v2 1/3] teams: Add a "get-maintainer" command Maxim Cournoyer
2022-12-27 15:32 ` [bug#60218] [PATCH v2 2/3] teams: Allow a patch-file argument to cc-members Maxim Cournoyer
2022-12-27 15:32 ` [bug#60218] [PATCH v2 3/3] .patman: New configuration file Maxim Cournoyer
2023-01-06 17:26 ` Simon Tournier
2023-01-11 15:10 ` zimoun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz858re8.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=60218@debbugs.gnu.org \
--cc=dev@jpoiret.xyz \
--cc=ludo@gnu.org \
--cc=mail@cbaines.net \
--cc=me@tobias.gr \
--cc=othacehe@gnu.org \
--cc=rekado@elephly.net \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.