all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: zimoun <zimon.toutoune@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>, jgart <jgart@dismail.de>
Cc: 60079@debbugs.gnu.org
Subject: [bug#60079] [PATCH] guix: gexp: Clarify what output can be in gexp module commentary.
Date: Fri, 06 Jan 2023 18:31:59 +0100	[thread overview]
Message-ID: <87cz7rh8mo.fsf@gmail.com> (raw)
In-Reply-To: <8735986fy6.fsf@gnu.org>

Hi,

On Wed, 21 Dec 2022 at 14:31, Ludovic Courtès <ludo@gnu.org> wrote:

>> --- a/guix/gexp.scm
>> +++ b/guix/gexp.scm
>> @@ -139,10 +139,11 @@ (define-module (guix gexp)
>>  ;;; This module implements "G-expressions", or "gexps".  Gexps are like
>>  ;;; S-expressions (sexps), with two differences:
>>  ;;;
>> -;;;   1. References (un-quotations) to derivations or packages in a gexp are
>> -;;;      replaced by the corresponding output file name; in addition, the
>> -;;;      'ungexp-native' unquote-like form allows code to explicitly refer to
>> -;;;      the native code of a given package, in case of cross-compilation;
>> +;;;   1. References (un-quotations) to derivations or packages in a gexp
>> +;;;   are replaced by the corresponding output store path or file name;
>> +;;;   in addition, the 'ungexp-native' unquote-like form allows code to
>> +;;;   explicitly refer to the native code of a given package, in case
>> +;;;   of cross-compilation;
>
> I prefer not to apply this patch: it worsens indentation and adds the
> words “store path”, which AFAICS bring nothing.

I agree.  Closing?

> Thanks anyway for taking a look,

Thanks.

Cheers,
simon




  reply	other threads:[~2023-01-06 18:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15  0:26 [bug#60079] [PATCH] guix: gexp: Clarify what output can be in gexp module commentary jgart via Guix-patches via
2022-12-21 13:31 ` Ludovic Courtès
2023-01-06 17:31   ` zimoun [this message]
2023-01-06 22:58   ` jgart via Guix-patches via

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cz7rh8mo.fsf@gmail.com \
    --to=zimon.toutoune@gmail.com \
    --cc=60079@debbugs.gnu.org \
    --cc=jgart@dismail.de \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.