From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Bruno Victal <mirai@makinata.eu>
Cc: me@tobias.gr, 61686@debbugs.gnu.org
Subject: [bug#61686] [PATCH] gnu: Add dropwatch.
Date: Fri, 24 Feb 2023 11:44:50 +0100 [thread overview]
Message-ID: <87cz5znxzx.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <43b683614e136e70894ba395a6759dc714fe2faf.1677006911.git.mirai@makinata.eu> (Bruno Victal's message of "Tue, 21 Feb 2023 19:19:55 +0000")
Hello,
Bruno Victal <mirai@makinata.eu> writes:
> * gnu/packages/networking.scm (dropwatch): New variable.
Thanks.
> ---
> Note: the kernel option NET_DROP_MONITOR must be set for this package
> to work.
Do you think it is worth mentioning in the description? AFAICT, Guix
does not set this option by default.
> +(define-public dropwatch
> + (package
> + (name "dropwatch")
> + (version "1.5.4")
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/nhorman/dropwatch.git")
You can drop the ".git" suffix here.
> + (commit (string-append "v" version))))
You also need to add
(file-name (git-file-name name version))
for proper naming in the store.
> + (sha256
> + (base32
> + "1r653y7bx763fpxl1vrflx8bzcrbds98zk4z7yhfikjngrqn1f2d"))))
> + (build-system gnu-build-system)
> + ;; XXX: bfd support isn't finished.
> + ;; https://github.com/nhorman/dropwatch/issues/76#issuecomment-1328345444
> + (arguments
> + (list #:configure-flags #~(list "--without-bfd")))
> + (native-inputs (list autoconf automake pkg-config))
> + (inputs (list libnl libpcap readline))
> + (home-page "https://github.com/nhorman/dropwatch")
> + (synopsis "Kernel dropped packet monitor")
> + (description
> + "dropwatch is an interactive utility for monitoring and
Nicpick: dropwatch —> Dropwatch
> +recording packets that are dropped by the kernel. It provides the commands
You need separate sentences with two spaces, per Texinfo syntax.
> +@command{dropwatch} and @command{dwdump}.")
> + (license license:gpl2+)))
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2023-02-24 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 19:19 [bug#61686] [PATCH] gnu: Add dropwatch Bruno Victal
2023-02-24 10:44 ` Nicolas Goaziou [this message]
2023-02-25 19:21 ` Bruno Victal
2023-02-25 20:01 ` Tobias Geerinckx-Rice via Guix-patches via
2023-02-25 20:55 ` [bug#61686] [PATCH v2] " Bruno Victal
2023-03-16 22:02 ` bug#61686: [PATCH] " Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cz5znxzx.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=61686@debbugs.gnu.org \
--cc=me@tobias.gr \
--cc=mirai@makinata.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.