all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Sharlatan Hellseher <sharlatanus@gmail.com>
Cc: 65118@debbugs.gnu.org
Subject: [bug#65118] [PATCH 0/9]: gnu: Add NSQ.
Date: Sat, 26 Aug 2023 22:13:43 -0400	[thread overview]
Message-ID: <87cyz9kzag.fsf_-_@gmail.com> (raw)
In-Reply-To: <3baf6e14e056d3b59288af505fc1eafd3d4c74d1.1691350701.git.sharlatanus@gmail.com> (Sharlatan Hellseher's message of "Sun, 6 Aug 2023 20:55:31 +0100")

Hi,

Sharlatan Hellseher <sharlatanus@gmail.com> writes:

> * gnu/packages/golang.scm (go-github-com-mreiferson-go-svc): New variable.
> ---
>  gnu/packages/golang.scm | 28 ++++++++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index ce46e02158..7890e4d583 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -6256,6 +6256,34 @@ (define-public go-github-com-mr-tron-base58
>  encoding and 8 times faster decoding.")
>        (license license:expat))))
>  
> +(define-public go-github-com-mreiferson-go-svc
> +  ;; NSQ specific fork of github.com/judwhite/go-svc, as Guix go build system
> +  ;; does not support go.mod with `replace' statement.
> +  (let ((commit "7a96e00010f68d9436e3de53a70c53f209a0c244")
> +        (revision "0"))
> +    (package
> +      (name "go-github-com-mreiferson-go-svc")
> +      (version (git-version "1.2.1" revision commit))
> +      (source (origin
> +                (method git-fetch)
> +                (uri (git-reference
> +                      (url "https://github.com/mreiferson/go-svc")
> +                      (commit commit)))
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1acgb0n3svhnraqj1fz5qc5n3b4vc5ffwyk9vfi6gcfkibm0hgmd"))))
> +      (build-system go-build-system)
> +      (arguments
> +       '(#:import-path "github.com/judwhite/go-svc"))
> +      (propagated-inputs (list go-golang-org-x-sys))
> +      (home-page "https://github.com/mreiferson/go-svc")
> +      (synopsis "Go Windows Service wrapper that plays nice with Linux")
> +      (description
> +       "Go Windows Service wrapper that plays nice with Linux.  Windows tests
> +@@url{https://github.com/judwhite/go-svc/raw/master/svc/svc_windows_test.go,here}.")
> +      (license license:expat))))

Reading this makes me wonder when the code path would ever be used on
GNU/Linux.  Probably never.  Perhaps an alternative would eb to edit it
out of the go.mod, if it still builds without too many problems.

Otherwise, LGTM.

-- 
Thanks,
Maxim




  reply	other threads:[~2023-08-27  2:14 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-06 19:54 [bug#65118] [PATCH 0/9]: gnu: Add NSQ Sharlatan Hellseher
2023-08-06 19:55 ` [bug#65118] [PATCH 1/9] gnu: Add go-github-com-bitly-go-hostpool Sharlatan Hellseher
2023-08-06 19:55 ` [bug#65118] [PATCH 2/9] gnu: Add go-github-com-bitly-timer-metrics Sharlatan Hellseher
2023-08-27  2:08   ` [bug#65118] [PATCH 0/9]: gnu: Add NSQ Maxim Cournoyer
2023-08-06 19:55 ` [bug#65118] [PATCH 3/9] gnu: Add go-github-com-bmizerany-perks-quantile Sharlatan Hellseher
2023-08-27  2:10   ` [bug#65118] [PATCH 0/9]: gnu: Add NSQ Maxim Cournoyer
2023-08-06 19:55 ` [bug#65118] [PATCH 4/9] gnu: Add go-github-com-mreiferson-go-svc Sharlatan Hellseher
2023-08-27  2:13   ` Maxim Cournoyer [this message]
2023-08-06 19:55 ` [bug#65118] [PATCH 5/9] gnu: Add go-github-com-julienschmidt-httprouter Sharlatan Hellseher
2023-08-27  2:14   ` [bug#65118] [PATCH 0/9]: gnu: Add NSQ Maxim Cournoyer
2023-08-06 19:55 ` [bug#65118] [PATCH 6/9] gnu: Add go-github-com-mreiferson-go-options Sharlatan Hellseher
2023-08-27  2:15   ` [bug#65118] [PATCH 0/9]: gnu: Add NSQ Maxim Cournoyer
2023-08-06 19:55 ` [bug#65118] [PATCH 7/9] gnu: Add go-github-com-nsqio-go-diskqueue Sharlatan Hellseher
2023-08-27  2:18   ` [bug#65118] [PATCH 0/9]: gnu: Add NSQ Maxim Cournoyer
2023-08-06 19:55 ` [bug#65118] [PATCH 8/9] gnu: Add go-github-com-nsqio-go-nsq Sharlatan Hellseher
2023-08-27  2:23   ` [bug#65118] [PATCH 0/9]: gnu: Add NSQ Maxim Cournoyer
2023-08-06 19:55 ` [bug#65118] [PATCH 9/9] gnu: Add nsq Sharlatan Hellseher
2023-08-27  2:02   ` [bug#65118] [PATCH 0/9]: gnu: Add NSQ Maxim Cournoyer
2023-08-26 16:17 ` [bug#65118] Sharlatan Hellseher
2023-08-27  2:24   ` [bug#65118] none Maxim Cournoyer
2023-09-01 19:57 ` [bug#65118] [PATCH v2 0/9] gnu: Add NSQ Sharlatan Hellseher
2023-09-01 19:58   ` [bug#65118] [PATCH v2 1/9] gnu: Add go-github-com-bitly-go-hostpool Sharlatan Hellseher
2023-09-01 19:58   ` [bug#65118] [PATCH v2 2/9] gnu: Add go-github-com-bitly-timer-metrics Sharlatan Hellseher
2023-09-01 19:58   ` [bug#65118] [PATCH v2 3/9] gnu: Add go-github-com-bmizerany-perks-quantile Sharlatan Hellseher
2023-09-01 19:58   ` [bug#65118] [PATCH v2 4/9] gnu: Add go-github-com-mreiferson-go-svc Sharlatan Hellseher
2023-09-01 19:58   ` [bug#65118] [PATCH v2 5/9] gnu: Add go-github-com-julienschmidt-httprouter Sharlatan Hellseher
2023-09-01 19:58   ` [bug#65118] [PATCH v2 6/9] gnu: Add go-github-com-mreiferson-go-options Sharlatan Hellseher
2023-09-01 19:58   ` [bug#65118] [PATCH v2 7/9] gnu: Add go-github-com-nsqio-go-diskqueue Sharlatan Hellseher
2023-09-01 19:58   ` [bug#65118] [PATCH v2 8/9] gnu: Add go-github-com-nsqio-go-nsq Sharlatan Hellseher
2023-09-01 19:58   ` [bug#65118] [PATCH v2 9/9] gnu: Add nsq Sharlatan Hellseher
2023-09-03 14:07 ` [bug#65118] Sharlatan Hellseher
2023-09-05  3:45   ` bug#65118: none Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87cyz9kzag.fsf_-_@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=65118@debbugs.gnu.org \
    --cc=sharlatanus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.