all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 34514@debbugs.gnu.org
Subject: [bug#34514] [PATCH 03/34] gnu: Add ruby-terraform.
Date: Tue, 19 Feb 2019 22:43:55 +0000	[thread overview]
Message-ID: <87bm37h00k.fsf@cbaines.net> (raw)
In-Reply-To: <874l90wwd6.fsf@elephly.net>

[-- Attachment #1: Type: text/plain, Size: 1002 bytes --]


Ricardo Wurmus <rekado@elephly.net> writes:

> Christopher Baines <mail@cbaines.net> writes:
>
>> * gnu/packages/ruby.scm (ruby-terraform): New variable.
> […]
>> +(define-public ruby-terraform
>> +  (package
>> +  (name "ruby-terraform")
>> +  (version "0.20.0")
>> +  (source
>> +    (origin
>> +      (method url-fetch)
>> +      (uri (rubygems-uri "ruby-terraform" version))
>> +      (sha256
>> +        (base32
>> +          "1czpak24v570ysnk8waj1sblfm1vqh1sdwh934x4ai90ribhlbzf"))))
>
> The indentation isn’t right here.

Good spot, I've fixed this now.

>> +  (build-system ruby-build-system)
>> +  (arguments
>> +   '(;; No included tests
>> +     #:tests? #f))
>
> Could you please put this all on one line?

Ok. I've taken to putting the comment inline, as this is syntactically
next to the #:tests? argument and this makes it easier to add additional
arguments, as you don't have to shuffle the comment around. I'm happy to
just put it inline though.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

  reply	other threads:[~2019-02-19 22:45 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-17 19:13 [bug#34514] [PATCH 00/34] Add more Ruby gems, some Rails related Christopher Baines
2019-02-17 19:22 ` [bug#34514] [PATCH 01/34] gnu: Add ruby-hamster Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 02/34] gnu: Add ruby-lino Christopher Baines
2019-02-18 22:42     ` Ricardo Wurmus
2019-02-17 19:22   ` [bug#34514] [PATCH 03/34] gnu: Add ruby-terraform Christopher Baines
2019-02-18 22:43     ` Ricardo Wurmus
2019-02-19 22:43       ` Christopher Baines [this message]
2019-02-17 19:22   ` [bug#34514] [PATCH 04/34] gnu: Add ruby-que Christopher Baines
2019-02-18 22:45     ` Ricardo Wurmus
2019-02-17 19:22   ` [bug#34514] [PATCH 05/34] gnu: Add ruby-rbnacl Christopher Baines
2019-02-18 22:47     ` Ricardo Wurmus
2019-02-19 22:20       ` Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 06/34] gnu: Add ruby-jwt Christopher Baines
2019-02-20 11:54     ` Ricardo Wurmus
2019-03-02 12:34       ` Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 07/34] gnu: Add ruby-multi-xml Christopher Baines
2019-02-20 17:04     ` Ricardo Wurmus
2019-03-02 12:36       ` Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 08/34] gnu: Add ruby-oauth2 Christopher Baines
2019-02-20 17:08     ` Ricardo Wurmus
2019-02-17 19:22   ` [bug#34514] [PATCH 09/34] gnu: Add ruby-omniauth Christopher Baines
2019-02-20 20:34     ` Ricardo Wurmus
2019-02-17 19:22   ` [bug#34514] [PATCH 10/34] gnu: Add ruby-warden Christopher Baines
2019-02-20 20:35     ` Ricardo Wurmus
2019-03-02 12:38       ` Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 11/34] gnu: Add ruby-warden-oauth2 Christopher Baines
2019-02-20 20:36     ` Ricardo Wurmus
2019-02-17 19:22   ` [bug#34514] [PATCH 12/34] gnu: Add ruby-with-advisory-lock Christopher Baines
2019-02-20 22:11     ` Ricardo Wurmus
2019-03-02 12:40       ` Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 13/34] gnu: Add ruby-omniauth-oauth2 Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 14/34] gnu: Add ruby-test-construct Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 15/34] gnu: Add ruby-minitest-around Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 16/34] gnu: Add libsass Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 17/34] gnu: sassc: Update and improve the package Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 18/34] gnu: Add ruby-sassc Christopher Baines
2019-02-17 19:22   ` [bug#34514] [PATCH 19/34] gnu: Add ruby-markaby Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 20/34] gnu: Add ruby-temple Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 21/34] gnu: Add ruby-haml Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 22/34] gnu: Add ruby-tilt Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 23/34] gnu: Add ruby-sass-rails Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 24/34] gnu: Add ruby-dep Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 25/34] gnu: ruby-jekyll-watch: Update to 2.1.2 Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 26/34] gnu: Remove ruby-listen-3.0 Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 27/34] gnu: ruby-listen: Enable running the tests Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 28/34] gnu: Add ruby-bindex Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 29/34] gnu: Add ruby-web-console Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 30/34] gnu: Add ruby-execjs Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 31/34] gnu: ruby: Update some RSpec packages Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 32/34] gnu: Add ruby-rspec-rails Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 33/34] gnu: Add ruby-autoprefixer-rails Christopher Baines
2019-02-17 19:23   ` [bug#34514] [PATCH 34/34] gnu: Add ruby-rerun Christopher Baines
2019-02-18 22:40   ` [bug#34514] [PATCH 01/34] gnu: Add ruby-hamster Ricardo Wurmus
2019-02-19 22:55     ` Christopher Baines
2019-02-20  7:48       ` Ricardo Wurmus
2019-03-05  7:51 ` [bug#34514] [PATCH 00/34] Add more Ruby gems, some Rails related Christopher Baines
2019-03-05  7:54 ` [bug#34514] [PATCH v2 01/12] gnu: Add ruby-sass-rails Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 02/12] gnu: Add ruby-dep Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 03/12] gnu: ruby-jekyll-watch: Update to 2.1.2 Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 04/12] gnu: Remove ruby-listen-3.0 Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 05/12] gnu: ruby-listen: Enable running the tests Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 06/12] gnu: Add ruby-bindex Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 07/12] gnu: Add ruby-web-console Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 08/12] gnu: Add ruby-execjs Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 09/12] gnu: ruby: Update some RSpec packages Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 10/12] gnu: Add ruby-rspec-rails Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 11/12] gnu: Add ruby-autoprefixer-rails Christopher Baines
2019-03-05  7:54   ` [bug#34514] [PATCH v2 12/12] gnu: Add ruby-rerun Christopher Baines
2019-03-24  9:43 ` bug#34514: [PATCH 00/34] Add more Ruby gems, some Rails related Christopher Baines

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bm37h00k.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=34514@debbugs.gnu.org \
    --cc=rekado@elephly.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.