all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: John Soo <jsoo1@asu.edu>
Cc: 40259-done@debbugs.gnu.org
Subject: bug#40259: [PATCH] gnu: Add emacs-evil-tmux-navigator
Date: Wed, 01 Apr 2020 09:11:48 +0100	[thread overview]
Message-ID: <87blobaam3.fsf@cbaines.net> (raw)
In-Reply-To: <87ftds42xp.fsf@asu.edu>

[-- Attachment #1: Type: text/plain, Size: 896 bytes --]


John Soo <jsoo1@asu.edu> writes:

> Hi Guix,
>
> I realized my last patch was based on previous work.
>
> I cherry-picked this one onto master.

Hi John,

Thanks for the patch. I've now pushed this as
1d5c93d9f8a13588695490db6516b40f54e91fa2.

I made a few changes, I move the package up from the bottom of the
file. I'd always recommend not adding new packages at the bottom of the
module files, as if everyone does this, it becomes harder to apply
patches because there are more conflicts. In this case, I think this
patch ended up conflicting with your addition of emacs-haskell-snippets,
also to the bottom of the emacs-xyz.scm file.

I also tweaked emacs-evil to be a propagated input, just because that
looked to be what the existing emacs-evil-... packages do, and I tweaked
the description to start with "This package lets you " so it reads as a
complete sentance.

Thanks again,

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 962 bytes --]

      reply	other threads:[~2020-04-01  8:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-27 21:46 [bug#40259] [PATCH] gnu: Add emacs-evil-tmux-navigator John Soo
2020-03-28 20:52 ` John Soo
2020-04-01  8:11   ` Christopher Baines [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blobaam3.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=40259-done@debbugs.gnu.org \
    --cc=jsoo1@asu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.