all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Ludovic Courtès" <ludo@gnu.org>
To: zimoun <zimon.toutoune@gmail.com>
Cc: 46391-done@debbugs.gnu.org
Subject: bug#46391: [PATCH 0/1] Canonicalize-path load-path option
Date: Wed, 24 Feb 2021 23:46:59 +0100	[thread overview]
Message-ID: <87blc92ie4.fsf@gnu.org> (raw)
In-Reply-To: <20210209004011.14176-1-zimon.toutoune@gmail.com> (zimoun's message of "Tue, 9 Feb 2021 01:40:11 +0100")

Hi!

zimoun <zimon.toutoune@gmail.com> skribis:

> This fixes <https://bugs.gnu.org/46390>.
>
> The test suite does not check relative path for the load-path option.
> I do not know what is the best to add a test about that.
>
> Last, I remember discussions about absolute/relative path and I do not know
> if this 'canonicalize-path' addition is the best fix here.
>
>
> All the best,
> simon
>
>
> zimoun (1):
>   scripts: build: Fix relative load-path.
>
>  guix/scripts/build.scm | 16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)

I’m discovering this after having independently addreses #46390, sorry
about that!  (Perhaps we should always send patches that fix bugs to the
corresponding bug report rather than/in addition to guix-patches?)

Let me know what you think.

Thanks,
Ludo’.




  parent reply	other threads:[~2021-02-24 22:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09  0:40 [bug#46391] [PATCH 0/1] Canonicalize-path load-path option zimoun
2021-02-24 12:18 ` zimoun
2021-02-24 22:46 ` Ludovic Courtès [this message]
2021-02-24 23:04   ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87blc92ie4.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=46391-done@debbugs.gnu.org \
    --cc=zimon.toutoune@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.