all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Oleg Pykhalov <go.wigust@gmail.com>
To: Jacob Adams <jacob@tookmund.com>
Cc: 50808@debbugs.gnu.org
Subject: [bug#50808] [PATCH] services: rsync: support binding rsync to a specific IP address
Date: Sun, 26 Sep 2021 18:24:46 +0300	[thread overview]
Message-ID: <87bl4fpdfl.fsf@gmail.com> (raw)
In-Reply-To: <20210926030511.17476-2-jacob@tookmund.com> (Jacob Adams's message of "Sat, 25 Sep 2021 23:05:11 -0400")

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Hi Jacob,

Nice catch, I would like to have this configurable, too.

Jacob Adams <jacob@tookmund.com> writes:

[…]

> +  (address       rsync-configuration-address              ; string
> +                 (default ""))

We could just use ‘#f’ here with ‘string | #f’ comment.

[…]

> +      (if (not (string=? address "")) (string-append "address = " address "\n") "")
>        "port = " (number->string port-number) "\n"
>        "use chroot = " (if use-chroot? "true" "false") "\n"
>        (if uid (string-append "uid = " uid "\n") "")

And here we could just ‘(if address (string-append ...) "")’.

Could you send an updated patch, please?

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 861 bytes --]

  reply	other threads:[~2021-09-26 15:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-26  3:05 [bug#50808] Jacob Adams
2021-09-26  3:05 ` [bug#50808] [PATCH] services: rsync: support binding rsync to a specific IP address Jacob Adams
2021-09-26 15:24   ` Oleg Pykhalov [this message]
2021-09-26  3:13 ` [bug#50808] Fixup bug title Jacob Adams
2021-09-26 17:31 ` [bug#50808] [PATCH v2] services: rsync: support binding rsync to a specific IP address Jacob Adams
2021-10-25 12:09   ` bug#50808: [PATCH] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bl4fpdfl.fsf@gmail.com \
    --to=go.wigust@gmail.com \
    --cc=50808@debbugs.gnu.org \
    --cc=jacob@tookmund.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.