From: pinoaffe <pinoaffe@airmail.cc>
To: Jelle Licht <jlicht@fsfe.org>
Cc: guix-devel@gnu.org
Subject: Re: Merging the “binary” NPM importer?
Date: Sun, 26 Sep 2021 23:34:57 +0200 [thread overview]
Message-ID: <87bl4fdnr2.fsf@airmail.cc> (raw)
In-Reply-To: <864ka7qwz1.fsf@fsfe.org>
Hi!
Jelle Licht writes:
> pinoaffe <pinoaffe@airmail.cc> writes:
>> I do however think that quite a couple of improvements would be
>> necessary before this can be merged
> The major ones I can think of are;
> - Be rebased on current master (or perhaps core-updates-fixed?)
> - tests
> - documentation
>
> Could you perhaps list some additional blockers? We can always refine
> and improve on an acceptable upstreamed version, since it will be a
> once-and-done tool instead of some stable API.
I think one would also need to deal with the fact that a recursive
import is likely to include several versions of the same package,
and I think rebasing might end up requiring a bit of rewriting since it
appears to me that some of the interfaces used in the guix-npm-binary
importer have changed since it was written
Kind regards,
pinoaffe
next prev parent reply other threads:[~2021-09-26 21:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-19 13:01 Adding extra package importers pinoaffe
2021-09-19 14:44 ` Maxime Devos
2021-09-23 20:28 ` Merging the “binary” NPM importer? Ludovic Courtès
2021-09-23 23:13 ` pinoaffe
2021-09-26 13:37 ` Jelle Licht
2021-09-26 21:34 ` pinoaffe [this message]
2021-09-26 22:32 ` Philip McGrath
2021-09-27 8:57 ` pinoaffe
2021-09-27 15:13 ` Katherine Cox-Buday
2021-09-28 12:37 ` Ludovic Courtès
2021-09-25 3:17 ` Christine Lemmer-Webber
2021-10-08 1:51 ` Maxim Cournoyer
2021-10-08 14:16 ` Katherine Cox-Buday
2021-10-11 10:13 ` zimoun
2021-10-11 17:12 ` pinoaffe
2021-10-12 18:21 ` Timothy Sample
2021-10-14 1:26 ` Maxim Cournoyer
2021-10-14 13:58 ` Ludovic Courtès
2021-10-14 14:54 ` Opining on "modern" development practices (was Re: Merging the “binary” NPM importer?) Katherine Cox-Buday
2021-10-21 19:39 ` Ludovic Courtès
2021-10-28 15:01 ` Katherine Cox-Buday
2021-10-29 12:33 ` Ludovic Courtès
2021-10-29 14:54 ` Katherine Cox-Buday
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl4fdnr2.fsf@airmail.cc \
--to=pinoaffe@airmail.cc \
--cc=guix-devel@gnu.org \
--cc=jlicht@fsfe.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.