all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Mathieu Othacehe <othacehe@gnu.org>
To: Andrew Patterson <andrewpatt7@gmail.com>
Cc: 57146@debbugs.gnu.org
Subject: [bug#57146] [PATCH] gnu: polkit: Fix cross-compiling
Date: Fri, 12 Aug 2022 10:29:34 +0200	[thread overview]
Message-ID: <87bksp27bl.fsf@gnu.org> (raw)
In-Reply-To: <20220811231100.22090-1-andrewpatt7@gmail.com> (Andrew Patterson's message of "Thu, 11 Aug 2022 19:11:00 -0400")


Hello Andrew,

> The polkit package used to refer to docbook-xsl via inputs rather native inputs,
> which obviously doesn't work when cross-compiling.

Thanks for working on that. It looks like this patch is breaking host
compilation:

--8<---------------cut here---------------start------------->8---
error: in phase 'fix-manpage-generation': uncaught exception:
wrong-type-arg "string-append" "Wrong type (expecting ~A): ~S" ("string" #f) (#f) 
phase `fix-manpage-generation' failed after 0.0 seconds
Backtrace:
           9 (primitive-load "/gnu/store/k2p4qxc23g871rm5q50bcx45f3m…")
In guix/build/gnu-build-system.scm:
    906:2  8 (gnu-build #:source _ #:outputs _ #:inputs _ #:phases . #)
--8<---------------cut here---------------end--------------->8---

Also you are doing a lot of things at the same time: fixing indentation,
introducing gexps, fixing cross-compilation. It would be great if you
could do that in separate patches to ease the review process.

Thanks,

Mathieu




  reply	other threads:[~2022-08-12  8:30 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 23:11 [bug#57146] [PATCH] gnu: polkit: Fix cross-compiling Andrew Patterson
2022-08-12  8:29 ` Mathieu Othacehe [this message]
2022-08-12 21:24   ` Andrew Patterson
2022-08-12  9:42 ` Jean Pierre De Jesus DIAZ via Guix-patches via
2022-08-12  9:57   ` Jean Pierre De Jesus DIAZ via Guix-patches via
2022-08-12 21:27     ` Andrew Patterson
2022-08-12 22:48       ` Jean Pierre De Jesus DIAZ via Guix-patches via
2022-08-14 10:06         ` Jean Pierre De Jesus DIAZ via Guix-patches via
2023-01-03 22:23       ` Maxim Cournoyer
2023-01-04  4:19         ` Andrew Patterson
2023-01-04  5:16           ` bug#57146: " Maxim Cournoyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bksp27bl.fsf@gnu.org \
    --to=othacehe@gnu.org \
    --cc=57146@debbugs.gnu.org \
    --cc=andrewpatt7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.