all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Christopher Baines <mail@cbaines.net>
To: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Cc: 60288@debbugs.gnu.org
Subject: [bug#60288] [RESEND #2] [PATCH v1 0/2] Start adding ZIM file(s)
Date: Wed, 28 Dec 2022 18:10:54 +0000	[thread overview]
Message-ID: <87bknn2y67.fsf@cbaines.net> (raw)
In-Reply-To: <20221220052349.4965-1-GNUtoo@cyberdimension.org>

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]


Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> writes:

> Here are two small patches.
>
> The first one add #:substitutable? to the copy-build system.
>
> I don't know how to check if it works as intended though. It's
> similar to the commit d0050ea8ad1c32d94cf5ba6725a0fc961bb23f38
> ("build-system/go: Add #:substitutable? argument.") so normally
> it shouldn't be an issue, but if someone can double check it it
> would be best as it would avoid keeping around substitutes of
> very big sizes.
>
> The second patch adds a ZIM file. I'll most likely send more
> patches to add additional ZIM files packages (about 10) later
> on. I prefer doing it this way as it avoids having to deal with
> potential rebases breaking if there is something wrong with my
> second patch.
>
> Denis 'GNUtoo' Carikli (2):
>   build-system/copy: Add #:substitutable? argument.
>   gnu: Add wikipedia_en_all_maxi

I haven't looked at this in detail, but one comment on the QA
failures. Building the package for this large file involves copying it
from the store, to another place in the store. This requires 2x the
space which this large file takes up, which is a pretty wasteful
approach.

This is the reason behind the build failures I've seen, the build
machines run out of space when attempting the file copy. Maybe an
alternative if you want to have a package would be to symlink to the
source. That way, there's only a large file and a symlink in the store,
rather than two copies of the same large file.

Chris

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]

  parent reply	other threads:[~2022-12-28 18:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23 22:07 [bug#60288] [RESEND #2] [PATCH v1 0/2] Start adding ZIM file(s) Denis 'GNUtoo' Carikli
2022-12-23 22:20 ` [bug#60288] [PATCH v1 1/2] build-system/copy: Add #:substitutable? argument Denis 'GNUtoo' Carikli
2022-12-23 22:20   ` [bug#60288] [PATCH v1 2/2] gnu: Add wikipedia_en_all_maxi Denis 'GNUtoo' Carikli
2022-12-28 18:10 ` Christopher Baines [this message]
2022-12-29 23:19   ` [bug#60288] [RESEND #2] [PATCH v1 0/2] Start adding ZIM file(s) Denis 'GNUtoo' Carikli
2023-01-02 20:01   ` Denis 'GNUtoo' Carikli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bknn2y67.fsf@cbaines.net \
    --to=mail@cbaines.net \
    --cc=60288@debbugs.gnu.org \
    --cc=GNUtoo@cyberdimension.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.