From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: 64317@debbugs.gnu.org
Subject: bug#64317: [Cuirass] Download products can disappear, leading to HTTP 500
Date: Tue, 27 Jun 2023 16:09:16 +0200 [thread overview]
Message-ID: <87bkh1uhdf.fsf@inria.fr> (raw)
The /download endpoint refers directly to store items. However, they
can be GC’d in the meantime, in which case the HTTP handler fails
gracelessly (HTTP 500 or so) as shown here:
--8<---------------cut here---------------start------------->8---
2023-06-27 16:02:24 GET /download/718
2023-06-27 16:02:24 Uncaught exception in task:
2023-06-27 16:02:24 In fibers.scm:
2023-06-27 16:02:24 172:8 1 (_)
2023-06-27 16:02:24 In ice-9/boot-9.scm:
2023-06-27 16:02:24 1685:16 0 (raise-exception _ #:continuable? _)
2023-06-27 16:02:24 ice-9/boot-9.scm:1685:16: In procedure raise-exception:
2023-06-27 16:02:24 In procedure open-file: No such file or directory: "/gnu/store/bnsh1yk4l913af8swqi3x7xp1xsa8gq7-guix-binary.tar.xz"
--8<---------------cut here---------------end--------------->8---
The solution IMO is to (1) register GC roots for these, (2) periodically
remove old GC roots, and (3) return 404 when the file has vanished.
Ludo’.
next reply other threads:[~2023-06-27 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-27 14:09 Ludovic Courtès [this message]
2023-08-24 15:22 ` bug#64317: [Cuirass] Download products can disappear, leading to HTTP 500 Ludovic Courtès
2023-08-26 20:15 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkh1uhdf.fsf@inria.fr \
--to=ludovic.courtes@inria.fr \
--cc=64317@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.