From: taylanbayirli@gmail.com (Taylan Ulrich Bayırlı/Kammer)
To: Andy Wingo <wingo@igalia.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] build: pull: Compile .scm files in one process.
Date: Thu, 12 Nov 2015 14:52:15 +0100 [thread overview]
Message-ID: <87a8qjtje8.fsf@T420.taylan> (raw)
In-Reply-To: <87y4e3l7hm.fsf@igalia.com> (Andy Wingo's message of "Thu, 12 Nov 2015 12:36:37 +0000")
[-- Attachment #1: Type: text/plain, Size: 842 bytes --]
Andy Wingo <wingo@igalia.com> writes:
> On Thu 12 Nov 2015 12:27, taylanbayirli@gmail.com (Taylan Ulrich "Bayırlı/Kammer") writes:
>
>> First attempt: when I simply put
>>
>> (for-each (lambda (file)
>> (display file)
>> (newline)
>> (primitive-load file))
>> files)
>>
>> before the named let loop, I get the following output (interesting bit
>> at the end, but all output pasted just in case):
>
> You'll want to do the primitive-load in a
>
> (save-module-excursion
> (lambda () (primitive-load file)))
>
> Andy
Heh, that was easy.
With that and your further help on IRC, I ended up with the following
patch.
This takes about 2 minutes on my system. The CPU gets fried during the
parallel compilation, as expected. ;-)
[-- Attachment #2: 0001-build-pull-Compile-.scm-files-in-one-process.patch --]
[-- Type: text/x-diff, Size: 8065 bytes --]
From 0eaf7d4c264dc531718a4c0b933323f48ea91930 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
<taylanbayirli@gmail.com>
Date: Thu, 5 Nov 2015 23:43:20 +0100
Subject: [PATCH] build: pull: Compile .scm files in one process.
* guix/build/pull.scm (call-with-process): Removed procedure.
(report-build-progress): Removed procedure.
(p-for-each): Removed procedure.
(build-guix): Don't create subprocesses to compile the .scm files.
---
guix/build/pull.scm | 140 +++++++++++++++++-----------------------------------
1 file changed, 46 insertions(+), 94 deletions(-)
diff --git a/guix/build/pull.scm b/guix/build/pull.scm
index 281be23..e525b7d 100644
--- a/guix/build/pull.scm
+++ b/guix/build/pull.scm
@@ -1,5 +1,6 @@
;;; GNU Guix --- Functional package management for GNU
;;; Copyright © 2013, 2014 Ludovic Courtès <ludo@gnu.org>
+;;; Copyright © 2015 Taylan Ulrich Bayırlı/Kammer <taylanbayirli@gmail.com>
;;;
;;; This file is part of GNU Guix.
;;;
@@ -22,6 +23,7 @@
#:use-module (ice-9 ftw)
#:use-module (ice-9 match)
#:use-module (ice-9 format)
+ #:use-module (ice-9 threads)
#:use-module (srfi srfi-1)
#:use-module (srfi srfi-11)
#:use-module (srfi srfi-26)
@@ -33,75 +35,10 @@
;;;
;;; Code:
-(define (call-with-process thunk)
- "Run THUNK in a separate process that will return 0 if THUNK terminates
-normally, and 1 if an exception is raised."
- (match (primitive-fork)
- (0
- (catch #t
- (lambda ()
- (thunk)
- (primitive-exit 0))
- (lambda (key . args)
- (print-exception (current-error-port) #f key args)
- (primitive-exit 1))))
- (pid
- #t)))
-
-(define* (report-build-progress total completed cont
- #:optional (log-port (current-error-port)))
- "Report that COMPLETED out of TOTAL files have been completed, and call
-CONT."
- (display #\cr log-port)
- (format log-port "compiling...\t~5,1f% of ~d files" ;FIXME: i18n
- (* 100. (/ completed total)) total)
- (force-output log-port)
- (cont))
-
-(define* (p-for-each proc lst
- #:optional (max-processes (current-processor-count))
- #:key (progress report-build-progress))
- "Invoke PROC for each element of LST in a separate process, using up to
-MAX-PROCESSES processes in parallel. Call PROGRESS at each step, passing it
-the continuation. Raise an error if one of the processes exit with non-zero."
- (define total
- (length lst))
-
- (define (wait-for-one-process)
- (match (waitpid WAIT_ANY)
- ((_ . status)
- (unless (zero? (status:exit-val status))
- (error "process failed" proc status)))))
-
- (let loop ((lst lst)
- (running 0)
- (completed 0))
- (match lst
- (()
- (or (zero? running)
- (let ((running (- running 1))
- (completed (+ completed 1)))
- (wait-for-one-process)
- (progress total completed
- (lambda ()
- (loop lst running completed))))))
- ((head . tail)
- (if (< running max-processes)
- (let ((running (+ 1 running)))
- (call-with-process (cut proc head))
- (progress total completed
- (lambda ()
- (loop tail running completed))))
- (let ((running (- running 1))
- (completed (+ completed 1)))
- (wait-for-one-process)
- (progress total completed
- (lambda ()
- (loop lst running completed)))))))))
-
(define* (build-guix out source
#:key gcrypt
- (debug-port (%make-void-port "w")))
+ (debug-port (%make-void-port "w"))
+ (log-port (current-error-port)))
"Build and install Guix in directory OUT using SOURCE, a directory
containing the source code. Write any debugging output to DEBUG-PORT."
(setvbuf (current-output-port) _IOLBF)
@@ -130,33 +67,48 @@ containing the source code. Write any debugging output to DEBUG-PORT."
(set! %load-path (cons out %load-path))
(set! %load-compiled-path (cons out %load-compiled-path))
- ;; Compile the .scm files. Do that in independent processes, à la
- ;; 'make -j', to work around <http://bugs.gnu.org/15602> (FIXME).
- ;; This ensures correctness, but is overly conservative and slow.
- ;; The solution initially implemented (and described in the bug
- ;; above) was slightly faster but consumed memory proportional to the
- ;; number of modules, which quickly became unacceptable.
- (p-for-each (lambda (file)
- (let ((go (string-append (string-drop-right file 4)
- ".go")))
- (format debug-port "~%compiling '~a'...~%" file)
- (parameterize ((current-warning-port debug-port))
- (compile-file file
- #:output-file go
- #:opts
- %auto-compilation-options))))
-
- (filter (cut string-suffix? ".scm" <>)
-
- ;; Build guix/*.scm before gnu/*.scm to speed
- ;; things up.
- (sort (find-files out "\\.scm")
- (let ((guix (string-append out "/guix"))
- (gnu (string-append out "/gnu")))
- (lambda (a b)
- (or (and (string-prefix? guix a)
- (string-prefix? gnu b))
- (string<? a b))))))))
+ ;; Compile the .scm files. Load all the files before compiling them to
+ ;; work around <http://bugs.gnu.org/15602> (FIXME).
+ (let* ((files
+ ;; gnu.scm depends on many other modules, so to avoid an early
+ ;; progress report stall, we move it to the end.
+ (sort (filter (cut string-suffix? ".scm" <>)
+ (find-files out "\\.scm"))
+ (lambda (a b)
+ (or (string-prefix? (string-append out "/gnu.scm") b)
+ (string<? a b)))))
+ (total (length files)))
+ (parameterize ((current-warning-port debug-port))
+ (let loop ((files files)
+ (completed 0))
+ (match files
+ (() *unspecified*)
+ ((file . files)
+ (display #\cr log-port)
+ (format log-port "loading...\t~5,1f% of ~d files" ;FIXME: i18n
+ (* 100. (/ completed total)) total)
+ (force-output log-port)
+ (save-module-excursion
+ (lambda () (primitive-load file)))
+ (loop files (+ 1 completed)))))
+ (newline)
+ (let ((mutex (make-mutex))
+ (completed 0))
+ (par-for-each
+ (lambda (file)
+ (with-mutex mutex
+ (display #\cr log-port)
+ (format log-port "compiling...\t~5,1f% of ~d files" ;FIXME: i18n
+ (* 100. (/ completed total)) total)
+ (force-output log-port)
+ (format debug-port "~%compiling '~a'...~%" file))
+ (let ((go (string-append (string-drop-right file 4) ".go")))
+ (compile-file file
+ #:output-file go
+ #:opts %auto-compilation-options))
+ (with-mutex mutex
+ (set! completed (+ 1 completed))))
+ files)))))
;; Remove the "fake" (guix config).
(delete-file (string-append out "/guix/config.scm"))
--
2.5.0
next prev parent reply other threads:[~2015-11-12 13:52 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-05 17:10 [PATCH] build: pull: Compile .scm files in one process Taylan Ulrich Bayırlı/Kammer
2015-11-05 21:06 ` Ludovic Courtès
2015-11-06 8:56 ` Taylan Ulrich Bayırlı/Kammer
2015-11-06 20:50 ` Ludovic Courtès
2015-11-07 9:54 ` Taylan Ulrich Bayırlı/Kammer
2015-11-10 18:00 ` Ludovic Courtès
2015-11-11 12:12 ` Taylan Ulrich Bayırlı/Kammer
2015-11-11 13:26 ` Ludovic Courtès
2015-11-12 10:23 ` Taylan Ulrich Bayırlı/Kammer
2015-11-12 12:07 ` Andy Wingo
2015-11-12 12:27 ` Taylan Ulrich Bayırlı/Kammer
2015-11-12 12:36 ` Andy Wingo
2015-11-12 13:52 ` Taylan Ulrich Bayırlı/Kammer [this message]
2015-11-12 20:44 ` Ludovic Courtès
2015-11-13 14:28 ` Taylan Ulrich Bayırlı/Kammer
2015-11-14 14:54 ` Ludovic Courtès
2015-11-26 22:20 ` Ludovic Courtès
2015-11-27 8:53 ` Taylan Ulrich Bayırlı/Kammer
2015-11-27 10:07 ` Ludovic Courtès
2015-11-27 15:16 ` Taylan Ulrich Bayırlı/Kammer
2015-11-30 13:04 ` Ludovic Courtès
2015-12-02 8:09 ` Taylan Ulrich Bayırlı/Kammer
2015-12-03 10:44 ` Ludovic Courtès
2015-12-21 9:49 ` Taylan Ulrich Bayırlı/Kammer
2016-01-05 17:56 ` Taylan Ulrich Bayırlı/Kammer
2016-01-05 21:39 ` Ludovic Courtès
2016-01-05 22:32 ` Taylan Ulrich Bayırlı/Kammer
2016-01-07 17:01 ` Leo Famulari
2016-01-07 17:54 ` Alex Sassmannshausen
2016-01-07 18:10 ` Ludovic Courtès
2015-12-03 15:27 ` Mark H Weaver
2015-12-03 15:54 ` Taylan Ulrich Bayırlı/Kammer
2015-12-04 14:11 ` Ludovic Courtès
2015-11-06 16:12 ` Andy Wingo
2015-11-06 16:41 ` Taylan Ulrich Bayırlı/Kammer
2015-11-06 20:48 ` Ludovic Courtès
2015-11-09 7:41 ` Andy Wingo
2015-11-09 8:51 ` Taylan Ulrich Bayırlı/Kammer
2015-11-09 9:07 ` Andy Wingo
2015-11-09 9:50 ` Taylan Ulrich Bayırlı/Kammer
2015-11-09 10:49 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8qjtje8.fsf@T420.taylan \
--to=taylanbayirli@gmail.com \
--cc=guix-devel@gnu.org \
--cc=wingo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.