Re: [PATCH 1/2] gnu: tlsdate: Use the system provided certificate store.

[ludo@gnu.org (Ludovic Courtès)]

Hello!

ng0 <ng0@libertad.pw> skribis:

> * gnu/packages/ntp.scm (tlsdate)[arguments]: Configure with unprivileged user and group.
> [arguments]: Build with the system provided certificates in a new phase.

[...]

> +     '(#:configure-flags '("--with-unpriv-user=tlsdate"
> +                           "--with-unpriv-group=tlsdate")

Why?  I think the default is nobody/nogroup, which is fine no?

> +       #:phases (modify-phases %standard-phases
> +                  (add-after 'unpack 'set-cert-path
> +                    ;; Use the system certificate store, not the
> +                    ;; application bundled certificates.
> +                    (lambda _
> +                      (substitute* "Makefile.am"
> +                        (("$(sysconfdir)/tlsdate/ca-roots/tlsdate-ca-roots.conf")
> +                         "/etc/ssl/certs/ca-certificates.crt"))))

I sympathize with this but this may or may not work on foreign distros.
Still, it’s probably better (this ‘tlsdata-ca-roots.conf’ file seems to
be a 4-year old copy from Mozilla’s NSS).

WDYT?

Thanks,
Ludo’.