From: ludo@gnu.org (Ludovic Courtès)
To: Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 6/6] gnu: Add neovim.
Date: Tue, 24 Jan 2017 22:31:13 +0100 [thread overview]
Message-ID: <87a8ag5en2.fsf@gnu.org> (raw)
In-Reply-To: <20170124144015.24473-6-ricardo.wurmus@mdc-berlin.de> (Ricardo Wurmus's message of "Tue, 24 Jan 2017 15:40:15 +0100")
Ricardo Wurmus <ricardo.wurmus@mdc-berlin.de> skribis:
> * gnu/packages/vim.scm (neovim): New variable.
[...]
> + (modify-phases %standard-phases
> + (add-after 'unpack 'set-lua-paths
> + (lambda* (#:key inputs #:allow-other-keys)
Maybe add a comment/link about the placeholder thing.
> + (inputs
> + `(("libuv" ,libuv)
> + ("gettext" ,gettext-minimal)
> + ("gperf" ,gperf)
I’d expect gettext and gperf to be native inputs instead?
Otherwise LGTM, thanks!
Ludo’.
next prev parent reply other threads:[~2017-01-24 21:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 14:40 [PATCH 1/6] gnu: Add libmpack Ricardo Wurmus
2017-01-24 14:40 ` [PATCH 2/6] gnu: Add lua-libmpack Ricardo Wurmus
2017-01-24 18:51 ` Leo Famulari
2017-01-25 9:18 ` Ricardo Wurmus
2017-01-24 14:40 ` [PATCH 3/6] gnu: Add lua5.2-libmpack Ricardo Wurmus
2017-01-24 14:40 ` [PATCH 4/6] gnu: Add lua5.2-bitop Ricardo Wurmus
2017-01-24 18:52 ` Leo Famulari
2017-01-25 9:17 ` Ricardo Wurmus
2017-01-24 14:40 ` [PATCH 5/6] gnu: Add lua5.2-lpeg Ricardo Wurmus
2017-01-26 18:01 ` Ludovic Courtès
2017-01-31 19:41 ` Ricardo Wurmus
2017-01-24 14:40 ` [PATCH 6/6] gnu: Add neovim Ricardo Wurmus
2017-01-24 21:31 ` Ludovic Courtès [this message]
2017-01-31 20:04 ` Ricardo Wurmus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a8ag5en2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guix-devel@gnu.org \
--cc=ricardo.wurmus@mdc-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.