From: Edouard Klein <edou@rdklein.fr>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 48059@debbugs.gnu.org, edouard@hex.lan
Subject: [bug#48059] [PATCH] gnu: python-libtmux: Fix build by removing tests broken by tmux update
Date: Tue, 27 Apr 2021 18:24:24 +0200 [thread overview]
Message-ID: <87a6pjofuv.fsf@rdklein.fr> (raw)
In-Reply-To: <8735vbsv7j.fsf@nckx>
Tobias Geerinckx-Rice writes:
> Edouard,
>
> Edouard Klein 写道:
>> tmux update from 3.1c to 3.2 breaks two tests in this package by quoting the
>> returned value of a tmux call. No harm done, a fix upstream is unlikely.
>
> Hm... why's that? Does upstream not support their own test suite?
>
The issue I opened last year about the two other tests failing is still
unresolved
https://github.com/tmux-python/libtmux/issues/281
There seems to be little ongoing development:
https://github.com/tmux-python/libtmux/commits/master
My suspicion is that the maintainer is using debian or another slow
distro that still use tmux 2, which I believe make the test pass (at
leat it did when I tested it last year)
https://packages.debian.org/buster/tmux
There is no way in Python to specify which version of tmux this is
supposed to run against. This is one of the strength of GNU Guix :)
So:
- the change in behaviour between tmux 2 and 3 is not
important enough to be noticeable in any of my use cases,
- I have little time,
- the maintainer upstream is likely using tmux 2,
all-in-all, this makes me say that an upstream fix is unlikely because I
can't write it myself and nobody else is likely to, either.
> Thanks!
>
Thank you for maintaining Guix :)
> T G-R
next prev parent reply other threads:[~2021-04-27 16:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 13:20 [bug#48059] [PATCH] gnu: python-libtmux: Fix build by removing tests broken by tmux update Edouard Klein
2021-04-27 13:39 ` Tobias Geerinckx-Rice via Guix-patches via
2021-04-27 16:24 ` Edouard Klein [this message]
2021-04-27 13:43 ` Tobias Geerinckx-Rice via Guix-patches via
2021-04-27 16:26 ` Edouard Klein
[not found] ` <handler.48059.B.161952974722963.ack@debbugs.gnu.org>
2021-05-28 7:38 ` [bug#48059] Acknowledgement ([PATCH] gnu: python-libtmux: Fix build by removing tests broken by tmux update) edk
2021-05-28 7:56 ` Maxime Devos
2021-05-28 16:17 ` Edouard Klein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6pjofuv.fsf@rdklein.fr \
--to=edou@rdklein.fr \
--cc=48059@debbugs.gnu.org \
--cc=edouard@hex.lan \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.