[bug#55060] [PATCH 5/6] gnu: Add python-scooby.

["Paul A. Patience" <paul@apatience.com>]

Hello Maxime,

I will reply to all of your comments below.

On 2022-04-22 13:53:46-04:00, Maxime Devos wrote:
> The 'python-' prefix is only for library-only python packages.  As it
> is a called tool, I assume there is some bin/scooby binary that the
> user would run?

It may be called a tool, but it is only a library, meant to be used from
other libraries.
The readme describes the basic usage as follows:

  import scooby
  scooby.Report()

On 2022-04-22 13:55:59-04:00, Maxime Devos wrote:
> Paul A. Patience schreef op vr 22-04-2022 om 01:03 [+0000]:
>> +    (native-inputs
>> +     (list python-beautifulsoup4
>> +           python-numpy
>> +           python-pytest
>> +           python-pytest-cov
>> +           python-scipy))
>> [no 'inputs' or 'propagated-inputs']
>
> Are these sufficient?  According to
> <https://github.com/banesullivan/scooby/blob/main/requirements.txt>,
> there is also a dependency on 'psutil' and 'mkl'.  I have also found
> references to those in non-test code.

The setup.py file lists psutil and mkl in extras_require, meaning they
are optional.
mkl (https://pypi.org/project/mkl/) is released under the Intel
Simplified Software License, which I suspect is ideologically
incompatible with Guix (and therefore not already packaged for Guix), so
I didn't include it.
I omitted psutil just because I was omitting mkl, but I can add it as a
propagated input.

On 2022-04-22 14:07:43-04:00, Maxime Devos wrote:
> Paul A. Patience schreef op vr 22-04-2022 om 01:03 [+0000]:
>> +               (("with pytest\\.raises\\(OSError\\):")
>> +                "with pytest.raises(ModuleNotFoundError):"))))
>
> What is this for?

It seems the test suite expects the import of a missing package to throw
an OSError instead of a ModuleNotFoundError, which is not the case at
least on Python 3.9.9.
I don't know if it was different before.
I can add a comment to that effect.

On 2022-04-22 13:51:26-04:00, Maxime Devos wrote:
> Paul A. Patience schreef op vr 22-04-2022 om 12:41 [+0000]:
>> +    (synopsis "Great Dane turned Python environment detective")
>
> What does this package have to do with Denmark and detectives?
>
> Looking further, ‘Great Dane’ appears to be some dog breed, and I guess
> it's a pun on the package name and Scooby-Doo.  However, I don't think
> this is useful for users looking for packages that suit their needs.
>
>> +    (description
>> +     "This is a lightweight tool for easily reporting your Python
>> +environment's package versions and hardware resources.")
>
> Isn't this just ‘guix package --list-installed=^python’?
> What hardware resources does it report?  CPU models?  Disk
> manufacturers?  The attached peripherals?  Non-physical peripherals
> like e.g. bluetooth mice?  The amount of ductape holding the computer
> together?  Information about the printer?  ...
>
> ALso, lightweight and easy is rather subjective.  Compares to lscpu,
> lspci, ..., (which are simple C tools IIUC) depending on python and
> python-scipy doesn't seem lightweight to me.  ‘(guix)Synopses and
> Descriptions’ recommends staying factual.

The synopsis and description are taken wholesale from Scooby's readme.
However, I can rewrite them.

Best regards,
Paul