all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Vagrant Cascadian <vagrant@debian.org>
To: Maxime Devos <maximedevos@telenet.be>, 55682@debbugs.gnu.org
Subject: [bug#55682] [PATCH V2 1/3] gnu: Add lcrq.
Date: Fri, 12 Aug 2022 11:15:30 -0700	[thread overview]
Message-ID: <87a6898h19.fsf@contorta> (raw)
In-Reply-To: <902b4751-ee88-fe46-8d68-b1a61605dce5@telenet.be>

[-- Attachment #1: Type: text/plain, Size: 899 bytes --]

On 2022-08-11, Maxime Devos wrote:
> On 31-07-2022 01:41, Vagrant Cascadian wrote:
>> +                  (replace 'check
>> +                    (lambda _
>> +                      (invoke "make" "test"))))))
>
> I expect "./pre-inst-env guix lint lcrq" to have a warning about 
> respecting #:tests?. This is important for --without-tests and 
> cross-compilation. Likewise for the other patches.

Oops. Looks like Efraim caught this after I pushed, at least.

>> +       #:make-flags (let ((target ,(%current-target-system)))
>> +                      (list ,(string-append "CC="
>> +                                            (cc-for-target))
>> +                            (string-append "PREFIX="
>> +                                           (assoc-ref %outputs "out"))))
> 'target' is unused and can be removed.

Nice catch, will look at it!


live well,
  vagrant

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

  reply	other threads:[~2022-08-12 18:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-27 19:10 [bug#55682] RFC packaging for lcsync Vagrant Cascadian
2022-05-27 19:27 ` Vagrant Cascadian
2022-05-27 19:27   ` Vagrant Cascadian
2022-07-30 23:39 ` Vagrant Cascadian
2022-07-30 23:41   ` [bug#55682] [PATCH V2 1/3] gnu: Add lcrq Vagrant Cascadian
2022-07-30 23:42     ` [bug#55682] [PATCH V2 2/3] gnu: Add librecast Vagrant Cascadian
2022-07-30 23:43       ` [bug#55682] [PATCH V2 3/3] gnu: Add lcsync Vagrant Cascadian
2022-08-11  9:48     ` [bug#55682] [PATCH V2 1/3] gnu: Add lcrq Maxime Devos
2022-08-12 18:15       ` Vagrant Cascadian [this message]
2022-08-11  2:32   ` bug#55682: RFC packaging for lcsync Vagrant Cascadian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6898h19.fsf@contorta \
    --to=vagrant@debian.org \
    --cc=55682@debbugs.gnu.org \
    --cc=maximedevos@telenet.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.