From: Christopher Baines <mail@cbaines.net>
To: Alexey Abramov <levenson@mmer.org>
Cc: 58989@debbugs.gnu.org
Subject: [bug#58989] [PATCH] services: gitolite: Add local-code configuration option.
Date: Sun, 06 Nov 2022 15:03:38 +0100 [thread overview]
Message-ID: <87a654gouw.fsf@cbaines.net> (raw)
In-Reply-To: <20221103161525.2130-1-levenson@mmer.org>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Alexey Abramov via Guix-patches via <guix-patches@gnu.org> writes:
> (match file
> - (($ <gitolite-rc-file> umask unsafe-pattern git-config-keys roles enable)
> + (($ <gitolite-rc-file> umask local-code unsafe-pattern git-config-keys roles enable)
> (apply text-file* "gitolite.rc"
> `("%RC = (\n"
> " UMASK => " ,(format #f "~4,'0o" umask) ",\n"
> " GIT_CONFIG_KEYS => '" ,git-config-keys "',\n"
> + ,(if local-code
> + (simple-format #f " LOCAL_CODE => \"~A\",\n" local-code))
> " ROLES => {\n"
> ,@(map (match-lambda
> ((role . value)
This generally looks good, but I believe the above will break if
local-code is #f.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 987 bytes --]
next prev parent reply other threads:[~2022-11-06 14:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-03 16:15 [bug#58989] [PATCH] services: gitolite: Add local-code configuration option Alexey Abramov via Guix-patches via
2022-11-06 14:03 ` Christopher Baines [this message]
2022-11-07 6:40 ` Alexey Abramov via Guix-patches via
2022-11-07 19:54 ` Christopher Baines
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a654gouw.fsf@cbaines.net \
--to=mail@cbaines.net \
--cc=58989@debbugs.gnu.org \
--cc=levenson@mmer.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.