From: "Ludovic Courtès" <ludo@gnu.org>
To: Nicolas Graves <ngraves@ngraves.fr>
Cc: 69052@debbugs.gnu.org
Subject: [bug#69052] [PATCH v2] gnu: guix: Correct home-channels-service-type extension logic.
Date: Sat, 02 Mar 2024 16:19:51 +0100 [thread overview]
Message-ID: <87a5ngek4o.fsf@gnu.org> (raw)
In-Reply-To: <20240225060917.12152-1-ngraves@ngraves.fr> (Nicolas Graves's message of "Sun, 25 Feb 2024 07:09:14 +0100")
Hi,
Nicolas Graves <ngraves@ngraves.fr> skribis:
> * gnu/home/services/guix.scm
> (extend-channel-list): Add function.
> (home-channels-service-type)[extend]: Use extend-channel-list.
>
> Change-Id: I587207b86216f075a54b6ed0b8fa998896bbed74
[...]
> +(define (channel-name-symbol channel)
> + (match (channel-name channel)
> + ((? symbol? name) name)
> + ((? string? name) (string->symbol name))))
‘channel-name’ always returns a symbol so this procedure can be removed.
> +(define (extend-channel-list default new)
> + "Prepend the channels in NEW by the channels in DEFAULT if their
> +channel-name is not in NEW."
> + (fold-right
> + (lambda (channel acc)
> + (if (member (channel-name channel) (map channel-name-symbol acc))
> + acc
> + (cons channel acc)))
> + new default))
[...]
> + (extend extend-channel-list)
I believe it’s equivalent to:
(define (extend-channel-list initial new)
(delete-duplicates
(append initial new)
(lambda (channel1 channel2)
(eq? (channel-name channel1) (channel-name channel2)))))
… which is somewhat clearer IMO.
Could you send an updated patch?
Ludo’.
next prev parent reply other threads:[~2024-03-02 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 12:44 [bug#69052] [PATCH] gnu: guix: Correct home-channels-service-type extension logic Nicolas Graves via Guix-patches via
2024-02-11 17:20 ` [bug#69052] Light rework needed Nicolas Graves via Guix-patches via
2024-02-25 6:09 ` [bug#69052] [PATCH v2] gnu: guix: Correct home-channels-service-type extension logic Nicolas Graves via Guix-patches via
2024-03-02 15:19 ` Ludovic Courtès [this message]
2024-04-13 23:33 ` [bug#69052] [PATCH v3] " Nicolas Graves via Guix-patches via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5ngek4o.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=69052@debbugs.gnu.org \
--cc=ngraves@ngraves.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.