From: Kei <kkebreau@posteo.net>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 41230-done@debbugs.gnu.org
Subject: bug#41230: [PATCH] gnu: Add libqglviewer.
Date: Wed, 13 May 2020 17:05:30 -0400 [thread overview]
Message-ID: <87a2a19ec23339c973e93bcbebf9dad21123ad16.camel@posteo.net> (raw)
In-Reply-To: <87d0771uju.fsf@elephly.net>
On Wed, 2020-05-13 at 21:52 +0200, Ricardo Wurmus wrote:
> Kei Kebreau <kkebreau@posteo.net> writes:
>
> > * gnu/packages/qt.scm (libqglviewer): New variable.
>
> Looks good to me!
>
> > + (arguments
> > + '(#:tests? #f ; no check target
> > + #:make-flags (list (string-append "PREFIX="
> > + (assoc-ref %outputs
> > "out")))
>
> Except for the formatting here. I’d break the line before “(list”.
>
Done and pushed to master as commit e792dd3244. Thanks for the review!
prev parent reply other threads:[~2020-05-13 21:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 12:44 [bug#41230] [PATCH] gnu: Add libqglviewer Kei Kebreau
2020-05-13 19:52 ` Ricardo Wurmus
2020-05-13 21:05 ` Kei [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a2a19ec23339c973e93bcbebf9dad21123ad16.camel@posteo.net \
--to=kkebreau@posteo.net \
--cc=41230-done@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.