From: Marius Bakke <mbakke@fastmail.com>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>, 30398@debbugs.gnu.org
Subject: [bug#30398] [PATCH 1/9] gnu: kde-frameworks: Update to 5.42.0 resp. 5.42.1
Date: Sun, 18 Feb 2018 18:16:51 +0100 [thread overview]
Message-ID: <878tbqtdz0.fsf@fastmail.com> (raw)
In-Reply-To: <20180208220237.13753-1-h.goebel@crazy-compilers.com>
[-- Attachment #1: Type: text/plain, Size: 4408 bytes --]
Hartmut Goebel <h.goebel@crazy-compilers.com> writes:
> Beside simple updating:
> - Change all todo-comments for test-cases into "fixme" comments to make them
> easier to find.
> - breeze-icons: Blacklist a test failing at build.kde.org, too.
> - extra-cmake-modules: Patch out a vanised test-case.
> - kfilemetadata: Can now run the test-suite uninstalled. Blacklist a failing
> test-case.
> - kimageformats: No longer symlink plugins into ./bin for testing.
> - ktexteditor: Remove now unused patch.
> - plasma-framework: Add input kirigami
> - sonnet: For testing set QT_QPA_PLATFORM=offscreen.
>
> * gnu/packages/kde-frameworks.scm (attica, baloo, bluez-qt, kactivities,
> kactivities-stats, kapidox, karchive, kauth, kbookmarks, kcmutils, kcodecs,
> kcompletion, kconfig, kconfigwidgets, kcoreaddons, kcrash, kdbusaddons,
> kde-frameworkintegration, kdeclarative, kded, kdelibs4support,
> kdesignerplugin, kdesu, kdewebkit, kdnssd, kdoctools, kemoticons,
> kglobalaccel, kguiaddons, khtml, ki18n, kiconthemes, kidletime, kinit, kio,
> kirigami, kitemmodels, kitemviews, kjobwidgets, kjs, kjsembed, kmediaplayer,
> knewstuff, knotifications, knotifyconfig, kpackage, kparts, kpeople,
> kplotting, kpty, kross, krunner, kservice, ksyntaxhighlighting,
> ktextwidgets, kunitconversion, kwallet, kwayland, kwindowsystem, kxmlgui,
> kxmlrpcclient, modemmanager-qt, networkmanager-qt, oxygen-icons,
> prison, solid, threadweaver): Update to 5.42.0.
> (kwidgetsaddons): Update to 5.42.1.
> (breeze-icons): Update to 5.42.0. [#:phases]<disable-failing-test> New
> phase.
> (extra-cmake-modules): Update to 5.42.0.
> [#:phases]<post-5.42.0-release-fix>: New phase.
> (kfilemetadata): Update to 5.42.0. [#:phases]: No longer move check behind
> install. [#:phases]<check-setup> Remove. [#:phase]<disable-failing-test> New
> phase.
> (kimageformats): Update to 5.42.0. [#:phases]<check-setup>: No longer
> symlink plugins into ./bin.
> (ktesteditor)[source]: Remove patch.
> (plasma-framework)[inputs]: Add kirigami
> (sonnet): Update to 5.42.0. [#:phases]<check-setup> New phase.
> * gnu/packages/patches/ktexteditor-5.39.0-autotests-dependencies.patch:
> Remove file.
> * gnu/local.mk (dist_patch_DATA): Remove it.
Wow, thanks for this!
[...]
> diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
> index 946c7511a..3642a866e 100644
> --- a/gnu/packages/kde-frameworks.scm
> +++ b/gnu/packages/kde-frameworks.scm
> @@ -74,7 +74,7 @@
> (define-public extra-cmake-modules
> (package
> (name "extra-cmake-modules")
> - (version "5.39.0")
> + (version "5.42.0")
> (source (origin
> (method url-fetch)
> (uri (string-append
> @@ -83,13 +83,20 @@
> name "-" version ".tar.xz"))
> (sha256
> (base32
> - "1ldwzx2bzlzw7r31w8zy08j4cn9q7d1kszc5jb22zhfqpvbkc1dq"))))
> + "1ml6s3ssr5izm3vnzlg5gn2nkcbz5l5nmapvyr4ml7n0089b43a3"))))
> (build-system cmake-build-system)
> (native-inputs
> `(("qtbase" ,qtbase))) ; For tests (needs qmake)
> (arguments
> `(#:phases
> (modify-phases %standard-phases
> + (add-after 'unpack 'post-5.42.0-release-fix
> + ;; FIXME: Remove for > 5.42.0
> + ;; ECMToolchainAndroidTest doesn't exist anymore
> + ;; https://cgit.kde.org/extra-cmake-modules.git/commit?id=30f31c46d8caf4
> + (lambda _
> + (substitute* "tests/CMakeLists.txt"
> + (("^add_test_macro\\(ECMToolchainAndroidTest dummy\\)") ""))))
#t))
[...]
> @@ -1333,8 +1351,16 @@ system.")
> name "-" version ".tar.xz"))
> (sha256
> (base32
> - "1b5bfjbpb6l3c9j9k42shhnz9lqqxk2g607qx9ni0n2pr7w2p7w1"))))
> + "1r3amddmy0nm8klw0jzvb8bl1l9hkrx50d8j0zq2lbjy36h3yliw"))))
> (build-system cmake-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-before 'check 'check-setup
> + (lambda* (#:key inputs #:allow-other-keys)
Just (lambda _ ...) is sufficient here.
The rest LGTM.
Side note: I think it's okay to push these changes directly instead of
going through the list as long as you are confident that they are
correct and everything builds.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-02-18 17:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 21:57 [bug#30398] [PATCH 0/9] Update KDE Frameworks to 5.42.0 and other KDE stuff respecrivly Hartmut Goebel
2018-02-08 22:02 ` [bug#30398] [PATCH 1/9] gnu: kde-frameworks: Update to 5.42.0 resp. 5.42.1 Hartmut Goebel
2018-02-08 22:02 ` [bug#30398] [PATCH 2/9] gnu: kpmcore: Update to 3.3.0 Hartmut Goebel
2018-02-08 22:02 ` [bug#30398] [PATCH 3/9] gnu: libksysguard: Update to 5.11.5 Hartmut Goebel
2018-02-08 22:02 ` [bug#30398] [PATCH 4/9] gnu: libkomparediff2: Update to 17.12.1 Hartmut Goebel
2018-02-08 22:02 ` [bug#30398] [PATCH 5/9] gnu: libkomparediff2: Use mirror://kde scheme for source-url Hartmut Goebel
2018-02-08 22:02 ` [bug#30398] [PATCH 6/9] gnu: snorenotify: " Hartmut Goebel
2018-02-08 22:02 ` [bug#30398] [PATCH 7/9] gnu: qca: " Hartmut Goebel
2018-02-08 22:02 ` [bug#30398] [PATCH 8/9] gnu: ktextwidgets: Add optional input "qtspeech" Hartmut Goebel
2018-02-08 22:02 ` [bug#30398] [PATCH 9/9] gnu: knotifications: " Hartmut Goebel
2018-02-18 17:16 ` Marius Bakke [this message]
2018-02-18 18:26 ` [bug#30398] [PATCH 1/9] Update KDE Frameworks to 5.42.0 and other Hartmut Goebel
2018-02-18 17:18 ` [bug#30398] [PATCH 0/9] Update KDE Frameworks to 5.42.0 and other KDE stuff respecrivly Marius Bakke
[not found] ` <handler.30398.B.151812708928561.ack@debbugs.gnu.org>
2018-02-18 17:40 ` bug#30398: ([PATCH 0/9] Update KDE Frameworks to 5.42.0 and other KDE stuff respectively) Hartmut Goebel
2018-02-18 17:51 ` bug#30340: Adopt NixOS patches for Qt5 Hartmut Goebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tbqtdz0.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=30398@debbugs.gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.